Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv] VCS UNR misses simple cases #14304

Open
matutem opened this issue Aug 16, 2022 · 7 comments
Open

[dv] VCS UNR misses simple cases #14304

matutem opened this issue Aug 16, 2022 · 7 comments
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR IP:clkmgr IP:sram_ctrl
Milestone

Comments

@matutem
Copy link
Contributor

matutem commented Aug 16, 2022

The VCS UNR flow misses the following simple cases for clkmgr:

  • The clkmgr output cg_en_o.aon_infra, cg_en_o.aon_powerup, and a few other members of cg_en_o were not found to be unreachable for toggle, even if they are driven by constants, like
    assign cg_en_o.aon_infra = MuBi4False;

  • The u_idle_cnt instance in module clkmgr_trans ties input step_i to a constant, but UNR fails to detect it won't toggle.

These issues were flagged to Synopsys.

Effort estimate is difficult to make, as it largely depends on vendor support.

estimate 8

@matutem matutem added the Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR label Aug 16, 2022
@msfschaffner msfschaffner added this to the Backlog milestone Sep 14, 2022
@weicaiyang
Copy link
Contributor

weicaiyang commented Jan 10, 2023

Found 2 similar cases in sram_ctrl.

  1. the inputs to u_seed_anchor are constant. anything uncovered in this instance should be unreachable, but VCS UNR can't catch it.
  2. This also has all constant inputs, which UNR fails to catch as well.

More are found in this file with annotation "[UNR] all inputs are constant".

Reported this to AE.

@weicaiyang
Copy link
Contributor

Found 2 similar cases in sram_ctrl.

  1. the inputs to u_seed_anchor are constant. anything uncovered in this instance should be unreachable, but VCS UNR can't catch it.
  2. This also has all constant inputs, which UNR fails to catch as well.

The VCS 2022.06-SP2 can't fix above issues, but it can catch the unreachable toggle coverage as inputs are constant, like this

@andreaskurth andreaskurth added IP:clkmgr IP:sram_ctrl Triaging:MultipleBlocks Issue is relevant for the triage of multiple HW blocks labels Feb 21, 2023
@andreaskurth
Copy link
Contributor

Triaged for sram_ctrl. Suggest M2.5 with Priority:P3 Priority: low because coverage numbers for that block are already well above 90%. If coverage would become a problem, though, this issue should be kept in mind.

@andreaskurth
Copy link
Contributor

andreaskurth commented Feb 27, 2023

Triaged for clkmgr, ditto, though even Priority:P4 Priority: propose to move to backlog would suffice.

@andreaskurth andreaskurth modified the milestones: Backlog, Discrete: M2.5 Feb 27, 2023
@andreaskurth andreaskurth added Priority:P4 Priority: propose to move to backlog Triaged and removed Triaging:MultipleBlocks Issue is relevant for the triage of multiple HW blocks labels Feb 27, 2023
@msfschaffner
Copy link
Contributor

Given that this seems to track a tooling issue and that we are otherwise in pretty good shape coverage-wise, I suggest to defer this to after M2.5.

@matutem
Copy link
Contributor Author

matutem commented Apr 13, 2023

Since this is a tooling issue I think the only impact it has for us is that we may need to add additional coverage exclusions manually. This means it is irrelevant, since we can reach adequate coverage with or without the vendor fixing this.

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
This was referenced Feb 12, 2024
@vogelpi
Copy link
Contributor

vogelpi commented Jun 14, 2024

@matutem , do you think this still persists with VCS U-2023.03-SP2 (the version most partners are using today)?

@moidx moidx removed Priority:P4 Priority: propose to move to backlog Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones labels Jun 14, 2024
@moidx moidx modified the milestones: Earlgrey-PROD.M5, Backlog Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR IP:clkmgr IP:sram_ctrl
Projects
None yet
Development

No branches or pull requests

6 participants