Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[entropy_src/dv] Complete extht verification #16276

Open
martin-lueker opened this issue Nov 11, 2022 · 6 comments
Open

[entropy_src/dv] Complete extht verification #16276

martin-lueker opened this issue Nov 11, 2022 · 6 comments
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Milestone:V3 Priority:P2 Priority: medium Subsystem:Entropy entropy_src, csrng, or edn related issues Type:Icebox Changes deferred to future milestones
Milestone
Backlog

Comments

@martin-lueker
Copy link
Contributor

  • Remove extht toggle and coverage exclusions
  • Implement continuous and windowed extht functionality in the extht agents
  • Revisit functional and toggle coverage, making vseq changes as necessary
@martin-lueker martin-lueker added Component:DV DV issue: testbench, test case, etc. Priority:P3 Priority: low IP:entropy_src Milestone:V3 Type:Icebox Changes deferred to future milestones labels Nov 11, 2022
@martin-lueker martin-lueker added this to the Project: M3 milestone Nov 11, 2022
@martin-lueker martin-lueker mentioned this issue Nov 11, 2022
Closed
@martin-lueker
Copy link
Contributor Author

Exclusion file in question:
https:/lowRISC/opentitan/pull/16256/files#diff-0e1ed0d4dc2f025f39e8cdc4859c4454fe37c30d82120d56c95a06610585c93f

@martin-lueker
Copy link
Contributor Author

Hi @sriyerg, as you requested.

@sriyerg
Copy link
Contributor

sriyerg commented Nov 11, 2022

Thanks @martin-lueker!

@sriyerg sriyerg removed the Priority:P3 Priority: low label Nov 11, 2022
@tjaychen
Copy link

Can someone remind us if the intent was to not verify this for ES and only for PROD?
That would be a reasonable approach in my mind.

@vogelpi vogelpi added Type:FutureRelease Not relevant to currently planned releases/milestones Triaged and removed Type:FutureRelease Not relevant to currently planned releases/milestones labels Feb 24, 2023
@vogelpi vogelpi modified the milestones: Discrete: M3, Backlog Feb 24, 2023
@vogelpi
Copy link
Contributor

vogelpi commented Feb 24, 2023 •
edited
Loading

In Earlgrey nothing is connected to the entropy_src_xht_i/o ports and we don't use external health tests. I've thus removed this from M3. Icebox seems right to me.

For Earglrey / M2.5 I actually suggest to disconnect the external health test agent in DV, this is captured in #17358.

@vogelpi vogelpi mentioned this issue Mar 21, 2023
Merged
andreaskurth added a commit to andreaskurth/opentitan that referenced this issue Jun 7, 2023
@andreaskurth
[entropy_src/dv] Link TODOs related to lowRISC#16276 to that issue
fe26162 
Signed-off-by: Andreas Kurth <[email protected]>
andreaskurth added a commit that referenced this issue Jun 13, 2023
@andreaskurth
[entropy_src/dv] Link TODOs related to #16276 to that issue
71f517d 
Signed-off-by: Andreas Kurth <[email protected]>
@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
@msfschaffner msfschaffner modified the milestones: Backlog, Earlgrey-PROD.M4 Nov 8, 2023
@msfschaffner msfschaffner added the Priority:P2 Priority: medium label Dec 4, 2023
@vogelpi vogelpi added the Subsystem:Entropy entropy_src, csrng, or edn related issues label Dec 21, 2023
@msfschaffner
Copy link
Contributor

Not planned for Earlgrey-PROD, since no external health tests are connected in that top-level.
Moving to backlog.

@msfschaffner msfschaffner added Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones and removed Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones labels Dec 21, 2023
This was referenced Mar 29, 2024
Closed
Closed
@vogelpi vogelpi mentioned this issue Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Milestone:V3 Priority:P2 Priority: medium Subsystem:Entropy entropy_src, csrng, or edn related issues Type:Icebox Changes deferred to future milestones
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@tjaychen @vogelpi @msfschaffner @sriyerg @martin-lueker