Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edn/dv] Implement my V2 Review TODO Items listed in Issue #11489 #12017

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

senelson7
Copy link
Contributor

Addresses items from Issue #11489 labeled "Steve:"

Signed-off-by: Steve Nelson [email protected]

@senelson7 senelson7 marked this pull request as ready for review April 8, 2022 20:45
@senelson7 senelson7 requested a review from a team as a code owner April 8, 2022 20:45
@senelson7 senelson7 requested review from rasmus-madsen, weicaiyang and mwbranstad and removed request for a team April 8, 2022 20:45
Copy link
Contributor

@mwbranstad mwbranstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weicaiyang weicaiyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weicaiyang weicaiyang merged commit 88a4bcc into lowRISC:master Apr 8, 2022
@senelson7 senelson7 deleted the edn_dv_new branch August 29, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants