[csrng/edn/rtl] Ensure enable in every state in main fsms #14534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hw/ip/csrng/rtl/csrng_cmd_stage.sv
Outdated
| @@ -193,7 +195,9 @@ module csrng_cmd_stage import csrng_pkg::*; #( | |||
| .cnt_next_o(), | |||
| .err_o(cmd_gen_cnt_err_o) | |||
| ); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Signed-off-by: Steve Nelson <[email protected]>
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this pull request
Nov 16, 2022
The reverted commit was originally introduced as part of lowRISC#14410 to work around a temporary issue until lowRISC#14534 got merged. It seems we forgot to remove that temporary work around before merging the PR. The workaround is critical because it weakens a security countermeasure inside CSRNG: errors injected into the command stage FSMs are no longer fatal. By disabling and re-enabling the module these FSMs can be made to leave the "terminal" error state. For this reason, we need to remove this workaround. This reverts commit f4df12f. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this pull request
Nov 16, 2022
The reverted commit was originally introduced as part of lowRISC#14410 to work around a temporary issue until lowRISC#14534 got merged. It seems we forgot to remove that temporary workaround before merging the PR. The workaround is critical because it weakens a security countermeasure inside CSRNG: errors injected into the command stage FSMs are no longer fatal. By disabling and re-enabling the module these FSMs can be made to leave the "terminal" error state. For this reason, we need to remove this workaround. This reverts commit f4df12f. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
added a commit
that referenced
this pull request
Nov 17, 2022
The reverted commit was originally introduced as part of #14410 to work around a temporary issue until #14534 got merged. It seems we forgot to remove that temporary workaround before merging the PR. The workaround is critical because it weakens a security countermeasure inside CSRNG: errors injected into the command stage FSMs are no longer fatal. By disabling and re-enabling the module these FSMs can be made to leave the "terminal" error state. For this reason, we need to remove this workaround. This reverts commit f4df12f. Signed-off-by: Pirmin Vogel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enable into every state in csrng & edn main fsms.
Signed-off-by: Steve Nelson [email protected]