Skip to content

Commit

Permalink
Revert "[csrng] Temporarily hack-in disable handling"
Browse files Browse the repository at this point in the history
The reverted commit was originally introduced as part of
lowRISC#14410 to work around a temporary issue until
lowRISC#14534 got merged. It seems we forgot to remove that
temporary workaround before merging the PR.

The workaround is critical because it weakens a security countermeasure
inside CSRNG: errors injected into the command stage FSMs are no longer
fatal. By disabling and re-enabling the module these FSMs can be made to
leave the "terminal" error state.

For this reason, we need to remove this workaround. This reverts commit
f4df12f.

Signed-off-by: Pirmin Vogel <[email protected]>
  • Loading branch information
vogelpi committed Nov 16, 2022
1 parent fc089bb commit be18aa1
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions hw/ip/csrng/rtl/csrng_cmd_stage.sv
Original file line number Diff line number Diff line change
Expand Up @@ -401,12 +401,6 @@ module csrng_cmd_stage import csrng_pkg::*; #(
cmd_stage_sm_err_o = 1'b1;
end
endcase // unique case (state_q)

// if disable, cycle back to Idle
if (!cs_enable_i && state_q != Idle) begin
state_d = Idle;
end

end

//---------------------------------------------------------
Expand Down

0 comments on commit be18aa1

Please sign in to comment.