[util,test] fix bug in flash scrambling script and add flash scrambling smoketest #17575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
requested review from
weicaiyang,
engdoreis,
cfrantz,
a team,
jdonjdon and
jadephilipoom
and removed request for
a team,
weicaiyang and
engdoreis
timothytrippel
force-pushed
the
add-flash-scrambling-smoketest
branch
from
269626d
to
eed0f85
Compare
6 tasks
The address used to compute the XEX scrambling mask was incorrect, as the VMEM file contains multiple flash word addresses in a line. Signed-off-by: Timothy Trippel <[email protected]>
This consolidates all flash_ctrl configurations to a single section in the test ROM to better mirror the actual ROM. Signed-off-by: Timothy Trippel <[email protected]>
This partially addresses lowRISC#14814. Signed-off-by: Timothy Trippel <[email protected]>
This adds a simple flash scrambling/ECC smoketest to DV to test the `gen-flash-img.py` can properly prepare a flash image for backdoor loading in flash in DV. This test is also added to the list of tests run in pre-submit CI. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
force-pushed
the
add-flash-scrambling-smoketest
branch
from
eed0f85
to
4fad90c
Compare
engdoreis
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This completes all tasks, and fixes #9322.
This also partially addresses #14814.