Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add DVsim support for the activity-checking part of power virus test #17800

Merged

Conversation

bilgiday
Copy link
Contributor

@bilgiday bilgiday commented Apr 4, 2023

  • C code:

    • Add adc_ctrl enablement code.
    • Fix pwm enablement code by adding phase_counter enablement.
  • chip_if.sv:

    • Add SignalProbe macros to monitor the states' of the active IPs
  • *_vseq.sv:

    • Modify the DV_WAIT macro's message to bring the activity closer the start of max power epoch.
    • Add a utility function to verify that all IPs are active at the beginning of the max-power epoch.

Checked DVsim on my local branch.

@bilgiday bilgiday requested review from a team as code owners April 4, 2023 00:08
@bilgiday bilgiday requested review from matutem, timothytrippel and cindychip and removed request for a team April 4, 2023 00:08
hw/top_earlgrey/dv/env/chip_if.sv Outdated Show resolved Hide resolved
hw/top_earlgrey/dv/env/chip_if.sv Outdated Show resolved Hide resolved
@bilgiday bilgiday force-pushed the power_virus_activity_chk_pr branch from 94baece to dde3feb Compare April 4, 2023 00:21
hw/top_earlgrey/dv/env/chip_if.sv Outdated Show resolved Hide resolved
hw/top_earlgrey/dv/env/chip_if.sv Outdated Show resolved Hide resolved
@bilgiday bilgiday force-pushed the power_virus_activity_chk_pr branch from dde3feb to 49b2e4f Compare April 4, 2023 00:34
Copy link
Contributor

@cindychip cindychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DV side LGTM!

Copy link
Contributor

@timothytrippel timothytrippel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise this looks great @bilgiday , thanks!

sw/device/tests/power_virus_systemtest.c Outdated Show resolved Hide resolved
@timothytrippel timothytrippel linked an issue Apr 4, 2023 that may be closed by this pull request
6 tasks
@bilgiday bilgiday force-pushed the power_virus_activity_chk_pr branch from 49b2e4f to 0ffaded Compare April 4, 2023 23:29
@bilgiday bilgiday force-pushed the power_virus_activity_chk_pr branch from 0ffaded to 23befc1 Compare April 4, 2023 23:50
…s test

- C code:
   - Add adc_ctrl enablement code.
   - Fix pwm enablement code by adding phase_counter enablement.

- chip_if.sv:
   - Add SignalProbe macros to monitor the states' of the active IPs

- *_vseq.sv:
   - Modify the DV_WAIT macro's message to bring the activity closer the start of max power epoch.
   - Add a utility function to verify that all IPs are active at the beginning of the max-power epoch.

Signed-off-by: Bilgiday Yuce <[email protected]>
@bilgiday bilgiday force-pushed the power_virus_activity_chk_pr branch from 23befc1 to 38165cd Compare April 5, 2023 00:27
@timothytrippel timothytrippel merged commit f1e4f2d into lowRISC:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chip-test] chip_sw_power_max_load
3 participants