[otp_ctrl] Filter ECC errors in partitions with no integrity #21256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfschaffner
force-pushed
the
otp-ecc-error-suppress
branch
from
0987f6a
to
3b06e55
Compare
msfschaffner
force-pushed
the
otp-ecc-error-suppress
branch
2 times, most recently
from
57fadd2
to
5755b19
Compare
Partitions with no integrity should not report any ECC related errors. In order to be on the safe side, we filter error responses in that case since they may trigger (unwanted) alerts. Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner
force-pushed
the
otp-ecc-error-suppress
branch
from
5755b19
to
c658c4f
Compare
a-will
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitions with no integrity should not report any ECC related errors.
In order to be on the safe side, we filter error responses in that case since they may trigger (unwanted) alerts.
This allows us to disable integrity on the VENDOR_TEST partition in Earlgrey discrete without having to change the internal behavior of the OTP wrapper.
@meisnere @arnonsha with this change, no further changes are required on the closed source side. The only thing that needs to be done is remapping of
ReadRaw -> ReadandWriteRaw -> Write.