Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added yandex.music & ok.ru support to MediaLinkExtension #193

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Added yandex.music & ok.ru support to MediaLinkExtension #193

merged 3 commits into from
Jan 8, 2018

Conversation

leotsarev
Copy link
Contributor

@leotsarev leotsarev commented Jan 8, 2018 •
edited
Loading

fixes #187

  • refactored MediaLinkExtensions to make it pluggable
  • add support for yandex.music (audio)
  • add support for ok.ru (video)
  • failed to add support for vk.ru (need to supply hash that could not be guessed from URI)
  • failed to add support for soundcloud (same reason)

@leotsarev leotsarev changed the title [WIP] Added yandex.music support to MediaLinkExtension Added yandex.music & ok.ru support to MediaLinkExtension Jan 8, 2018
@leotsarev
Copy link
Contributor Author

No longer WIP, please review

@xoofx xoofx merged commit 8e15c8b into xoofx:master Jan 8, 2018
@xoofx
Copy link
Owner

xoofx commented Jan 8, 2018

Thanks!

@leotsarev leotsarev deleted the support-vk-and-yandex-music branch January 8, 2018 17:26
@leotsarev
Copy link
Contributor Author

Thanks to you! If you will ping me about release of NuGet, I'll greatly appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media extensions — add support for Yandex.Music & VK
2 participants
@leotsarev @xoofx