Allow #, ? and : instead of only / as the domain separator for AutoLinks #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -690,7 +690,7 @@ public static bool IsValidDomain(string link, int prefixLength) | |||
|
|
|||
| if (!c.IsAlphaNumeric()) | |||
| { | |||
| if (c == '/') // End of domain name | |||
| if (c == '/' || c == '?' || c == '#' || c == ':') // End of domain name | |||
There was a problem hiding this comment.
Just an opinion:
this could perhaps also be written as:
if ("/?#:".Contains(c))This would allow it to be extended to more characters in the future if needed (well, easier to extend).
Don't know if there is any performance difference though.
There was a problem hiding this comment.
Up to personal taste I guess.
Performance-wise it doesn't really matter in this case, I just try to stick to the same style as the rest of the library.
There was a problem hiding this comment.
Just made a benchmark comparison for 5 characters in a tests (between contains and ==)
Method | Mean | Error | StdDev | Median |
--------- |---------:|----------:|----------:|---------:|
Contains | 641.7 ns | 12.833 ns | 31.959 ns | 629.5 ns |
Equals | 254.1 ns | 5.030 ns | 8.403 ns | 253.0 ns |
And it seems that Equals is still faster. So yeah, let's keep equals in that case
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #258
The issue with the Specs file remains, do you want me to commit it anyway?