Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config migration logic causes kits to deinit on re-upgrade #196

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fix: config migration logic causes kits to deinit on re-upgrade #196

merged 1 commit into from
Jul 1, 2022

Conversation

willpassidomo
Copy link
Contributor

Summary

  • Customer reported an odd issue where the kits are briefly initializing, de-initializing then re-initializing again on startup. I have been unable to reproduce, but based on the provided logs, it appears to be related to our migration logic released in v5.36.0. This fix adds a flag that ensures our migration logic attempted exactly 1-time per device

Testing Plan

  • none at this time

Master Issue

@willpassidomo willpassidomo force-pushed the fix/SQDSDKS-4265-config-migration-reload-empty branch 2 times, most recently from 00f3857 to d3cfdc5 Compare July 1, 2022 19:18
@willpassidomo willpassidomo force-pushed the fix/SQDSDKS-4265-config-migration-reload-empty branch from d3cfdc5 to 0449e41 Compare July 1, 2022 19:54
@willpassidomo willpassidomo merged commit ae210c4 into development Jul 1, 2022
@willpassidomo willpassidomo deleted the fix/SQDSDKS-4265-config-migration-reload-empty branch July 1, 2022 20:15
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
@mparticle-automation
chore(release): 5.41.3
4d4b51c 
## [5.41.3](v5.41.2...v5.41.3) (2022-07-01)

### Bug Fixes

* config migration logic causes kits to deinit on re-upgrade ([#196](#196)) ([ae210c4](ae210c4))
* modify() call throws an exception when user is not present ([#195](#195)) ([72731d5](72731d5))

### Updates & Maintenance

* Update Submodules ([99fed27](99fed27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchuangatmp mchuangatmp mchuangatmp approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willpassidomo @mparticle-automation @mchuangatmp