Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ported Android Kit Base tests to Kotlin #253

Conversation

FelipeCoro
Copy link
Contributor

Summary

Ported both unit and instrumented test from Java to Kotlin

Testing Plan

All test passed.

Reference Issue

Closes https://go.mparticle.com/work/SQDSDKS-4604

@mchuangatmp mchuangatmp self-requested a review October 12, 2022 15:31
@mchuangatmp mchuangatmp force-pushed the feat/SQDSDK-4604-Port_Android_kit_base_java_instrumented_and_unit_tests_to_kotlin_ branch from ad19ba4 to dbda118 Compare October 12, 2022 19:45
@mchuangatmp mchuangatmp merged commit c21dd71 into mParticle:development Oct 12, 2022
mparticle-automation added a commit that referenced this pull request Oct 14, 2022
## [5.46.0](v5.45.2...v5.46.0) (2022-10-14)

### Features

* Bump up compile SDK to 33 and ktlint version ([#245](#245)) ([67dc378](67dc378))
* Port android core module java instrumented and unit tests to kotlin - phase1 ([#249](#249)) ([62e4254](62e4254))
* Port android core module java instrumented and unit tests to kotlin (p2) ([#250](#250)) ([23434d2](23434d2))
* Ported Android Kit Base tests to Kotlin ([#253](#253)) ([c21dd71](c21dd71))
* update isLimitAdTracking logic for Android 13 ([#233](#233)) ([f7b9284](f7b9284))

### Bug Fixes

* Convert MParticleTest.java file to kotlin and fix failing test ([#251](#251)) ([604c1b9](604c1b9))

### Documentation

* Update copy in readme for android 13 ([#255](#255)) ([c9a648d](c9a648d))

### Updates & Maintenance

* add in missing inherit in rebase job ([2197610](2197610))
* Update submodules ([7bdaf63](7bdaf63))
* Update to kotlin 1.7.20 ([#247](#247)) ([c9e1729](c9e1729))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants