Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to Manifest v3 #316

Open
machawk1 opened this issue Dec 9, 2020 · 6 comments
Open

Adapt to Manifest v3 #316

machawk1 opened this issue Dec 9, 2020 · 6 comments
Labels
associated branch Indicates whether there is a separate branch associated with the issue enhancement

Comments

@machawk1
Copy link
Owner

machawk1 commented Dec 9, 2020 •
edited
Loading

Per https://blog.chromium.org/2020/12/manifest-v3-now-available-on-m88-beta.html, manifest version 3 is available for testing in Chrome 88 beta. Of significance is the deprecation of background scripts in favor of service workers.

Barriers: TBD

Branch: issue-316
machawk1 added a commit that referenced this issue Dec 27, 2020
@machawk1
Use chrome.runtime, not deprecated chrome.extension for #316
5706033
@machawk1
Copy link
Owner Author

machawk1 commented May 5, 2021

Now available in Chrome 88 (current is v90) and documentation says that the Chrome Web Store has been accepting extensions with manifest v3 since January 2021.

@machawk1 machawk1 changed the title Prepare for Manifest v3 Adapt to Manifest v3 Jun 14, 2021
@machawk1
Copy link
Owner Author

https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
To be deprecated for existing extensions in January 2023

@machawk1 machawk1 added the associated branch Indicates whether there is a separate branch associated with the issue label Dec 2, 2021
@machawk1 machawk1 mentioned this issue Jun 22, 2022
Open
@machawk1 machawk1 pinned this issue Oct 28, 2022
machawk1 added a commit that referenced this issue Aug 24, 2023
@machawk1
Merge branch 'main' into issue-316
7ff1fa1 
Update closer to MV3 (#316)  by adapting fetch to catch 5XXs.
Improve flow of catching and calling, still not yet complete.
Re:#343 to better adapt fall-through logic, too.
@machawk1
Copy link
Owner Author

A bit was done in the issue-316 branch. The current state has fetches via the aggregator but the pageAction does not invoke correctly per the newer MV3 paradigms. One current issue is injecting the minkui.html page, previously done via a $.ajax fetch. There is probably a better, more native way to accomplish this.

machawk1 added a commit that referenced this issue Nov 2, 2023
@machawk1
Adapt to use Manifest v3 per #316
a32a89c
@machawk1
Copy link
Owner Author

machawk1 commented Nov 2, 2023

The core logic to adapt Mink to MV3 was done in a32a89c. Some subtle issues remain like the pageAction animation but this issue is 90% complete.

machawk1 added a commit that referenced this issue Nov 2, 2023
@machawk1
Fix toggle by rm'ing listener after UI creation for #316
871978f
@machawk1
Copy link
Owner Author

machawk1 commented Nov 2, 2023

The drilldown Miller columns interface appears to be broken in the latest issue-316 branch after the move to Service Workers.

machawk1 added a commit that referenced this issue Oct 14, 2024
@machawk1
Add fallthrough aggregator logic for #316 and #367
aeacb6a
This was referenced Oct 14, 2024
Closed
Open
Open
@machawk1
Copy link
Owner Author

  • Enable tmData in displayMinkUI.js (to allow drilldown to function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
associated branch Indicates whether there is a separate branch associated with the issue enhancement
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue-316 machawk1/Mink
1 participant
@machawk1