Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall-through to secondary aggregator when primary aggregator returns an HTML page for a TimeMap #367

Closed
machawk1 opened this issue Oct 10, 2024 · 5 comments
Labels

Comments

@machawk1
Copy link
Owner

machawk1 commented Oct 10, 2024

ODU's MemGator instance is returning an HTML authentication page.

https://memgator.cs.odu.edu/timemap/json/https://www.cs.odu.edu/~mln/
Screenshot 2024-10-10 at 5 07 37 PM

Mink reports this as an "error fetching" despite the 200, so never resolves. This should be a case for a fall-through aggregator.

EDIT: I encountered this issue when testing for the HEAD of the issue-316 branch (MV3 migration).

@machawk1 machawk1 added the bug label Oct 10, 2024
@machawk1
Copy link
Owner Author

Related to #343

@machawk1
Copy link
Owner Author

This is a SyntaxError that should be caught.

@machawk1
Copy link
Owner Author

This boils down to the response.json() parsing failing in the Promise.

@machawk1
Copy link
Owner Author

machawk1 commented Oct 10, 2024

A catch for this is in the issue-316 branch but I need to evaluate if the aggregator fall-through logic is in-place

  • Check if the aggregator fall-through logic is in-place in the MV3 branch (issue-316)
    • It is not.
  • Invoked the switch logic in mink.js as applicable

@machawk1
Copy link
Owner Author

Fall-through logic implemented in aeacb6a, requires resolution of #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant