deprecate rejectWithResponse=false #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sdebarros we'll have to release this before #1933 - I only realized this was missing when reviewing your PR. |
marcoow
force-pushed
the
reject-with-response-deprecation
branch
from
357a3f2
to
7a43ca8
Compare
2 tasks
sdebarros
reviewed
Oct 29, 2019
sdebarros
reviewed
Oct 29, 2019
marcoow
force-pushed
the
reject-with-response-deprecation
branch
from
7a43ca8
to
526ec00
Compare
marcoow
force-pushed
the
reject-with-response-deprecation
branch
from
526ec00
to
9bec125
Compare
sdebarros
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates relying on the current default value of
falsefor therejectWithResponsein the OAuth 2.0 Password Grant and Devise authenticators. We want to remove the property in the future and need everyone to switch to the new behavior before we can do that. That deprecation should have been added long ago already 🤦♂