deprecate rejectWithResponse=false

addon/authenticators/devise.js

@@ -3,6 +3,7 @@ import { isEmpty } from '@ember/utils';
 import { run } from '@ember/runloop';
 import { merge, assign as emberAssign } from '@ember/polyfills';
 import { computed } from '@ember/object';
+import { deprecate } from '@ember/application/deprecations';
 import BaseAuthenticator from './base';
 import fetch from 'fetch';
 
@@ -140,6 +141,14 @@ export default BaseAuthenticator.extend({
  authenticate(identification, password) {
  return new Promise((resolve, reject) => {
  const useResponse = this.get('rejectWithResponse');
+
+ if (!useResponse) {
+ deprecate('Ember Simple Auth: The default value of false for the rejectWithResponse property should no longer be relied on; instead set the property to true to enable the future behavior.', false, {
+ id: `ember-simple-auth.authenticator.no-reject-with-response`,
+ until: '2.0.0'
+ });
+ }
+
  const { resourceName, identificationAttributeName, tokenAttributeName } = this.getProperties('resourceName', 'identificationAttributeName', 'tokenAttributeName');
  const data = {};
  data[resourceName] = { password };

addon/authenticators/oauth2-password-grant.js

@@ -280,6 +280,14 @@ export default BaseAuthenticator.extend({
  const data = { 'grant_type': 'password', username: identification, password };
  const serverTokenEndpoint = this.get('serverTokenEndpoint');
  const useResponse = this.get('rejectWithResponse');
+
+ if (!useResponse) {
+ deprecate('Ember Simple Auth: The default value of false for the rejectWithResponse property should no longer be relied on; instead set the property to true to enable the future behavior.', false, {
+ id: `ember-simple-auth.authenticator.no-reject-with-response`,
+ until: '2.0.0'
+ });
+ }
+
  const scopesString = makeArray(scope).join(' ');
  if (!isEmpty(scopesString)) {
  data.scope = scopesString;

tests/unit/authenticators/devise-test.js

@@ -1,4 +1,5 @@
 import { tryInvoke } from '@ember/utils';
+import { registerDeprecationHandler } from '@ember/debug';
 import {
  describe,
  beforeEach,
@@ -62,6 +63,20 @@ describe('DeviseAuthenticator', () => {
  });
  });
 
+ it('shows a deprecation warning when rejectWithResponse is not enabled', function() {
+ authenticator.set('rejectWithResponse', false);
+
+ let warnings = [];
+ registerDeprecationHandler((message, options, next) => {
+ warnings.push(message);
+ next(message, options);
+ });
+
+ return authenticator.authenticate('identification', 'password').then(() => {
+ expect(warnings[0]).to.eq('Ember Simple Auth: The default value of false for the rejectWithResponse property should no longer be relied on; instead set the property to true to enable the future behavior.');
+ });
+ });
+
  describe('when the authentication request is successful', function() {
  beforeEach(function() {
  server.post('/users/sign_in', () => [201, { 'Content-Type': 'application/json' }, '{ "token": "secret token!", "email": "[email protected]" }']);

tests/unit/authenticators/oauth2-password-grant-test.js

@@ -196,6 +196,27 @@ describe('OAuth2PasswordGrantAuthenticator', () => {
  authenticator.authenticate('username', 'password', ['public', 'private']);
  });
 
+ it('shows a deprecation warning when rejectWithResponse is not enabled', function(done) {
+ authenticator.set('rejectWithResponse', false);
+ server.post('/token', (request) => {
+ let { requestBody } = request;
+ let { scope } = parsePostData(requestBody);
+ expect(scope).to.eql('public private');
+ done();
+ });
+
+ let warnings = [];
+ registerDeprecationHandler((message, options, next) => {
+ warnings.push(message);
+ next(message, options);
+ });
+
+ server.post('/token', () => done());
+ authenticator.authenticate('username', 'password');
+
+ expect(warnings[1]).to.eq('Ember Simple Auth: The default value of false for the rejectWithResponse property should no longer be relied on; instead set the property to true to enable the future behavior.');
+ });
+
  describe('when the authentication request is successful', function() {
  beforeEach(function() {
  server.post('/token', () => [200, { 'Content-Type': 'application/json' }, '{ "access_token": "secret token!" }']);