Verification request and QR listener in Crypto V2 #1663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate verification signalling which exposes state stream for
VerificationRequest
andQrCode
the same way as was previously done forSAS
. This makes it possible to completely removeupdatePendingVerification
method which manually compares the state of verification objects.There are a few things that this PR does not address yet and will be resolved in future PR:
actor
type to make concurrency more rigorousprocessOutgoingRequests
from multiple places also makes it less obvious when and how this should be called (after sync, after decrypting events, ...)