Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification request and QR signalling #1272

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Verification request and QR signalling #1272

merged 2 commits into from
Dec 14, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Dec 13, 2022

This change is a continuation of adding signalling to SAS verification, adding changes stream to VerificationRequest and QrCode

@Anderas Anderas force-pushed the andy/verification_changes branch 2 times, most recently from a031f1d to d8e3ace Compare December 14, 2022 11:48
@Anderas Anderas marked this pull request as ready for review December 14, 2022 11:48
@Anderas Anderas requested a review from poljar December 14, 2022 12:00
poljar
poljar reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only question remains. Do we need the accepted verification methods exposed in the bindings.

bindings/matrix-sdk-crypto-ffi/src/verification.rs Show resolved Hide resolved
crates/matrix-sdk-crypto/src/verification/sas/mod.rs Show resolved Hide resolved
@Anderas Anderas requested a review from poljar December 14, 2022 15:08
poljar
poljar approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@Anderas Anderas closed this Dec 14, 2022
@Anderas Anderas reopened this Dec 14, 2022
@poljar poljar merged commit 9239470 into main Dec 14, 2022
@poljar poljar deleted the andy/verification_changes branch December 14, 2022 18:15
@Anderas Anderas mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anderas @poljar