-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[delocate-addplat] parse_wheel_filename
may return wrong package name
#175
Labels
Comments
duburcqa
changed the title
[delocate-addplat]
[delocate-addplat] Jan 26, 2023
parse_wheel_filename
wrong if package name contains dashparse_wheel_filename
may return wrong package name
Happening for psycopg too: https:/psycopg/psycopg2/actions/runs/4525821909/jobs/7972760651 |
FYI, we solved the problem by using cibuildwheel, instead of using delocate from a job we rolled on owr own. So probably the problem was in the options used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
parse_wheel_filename
method that is involved in the CLI commanddelocate-addplat
returns the "canonical" package name as first output argument, i.e. underscores are replaced by dashes if any. This name is then used to defined where to find thedist-info
. However, the name that is actually used to prependdist-info
is actually doing the contrary (using dashes in place of underscores), leading to failure.To Reproduce
Here is an example of such a failure:
The complete log file is available here.
Expected behavior
The package names used to create and search
dist-info
should be consistent.Wheels used
Could be added if necessary
Platform (please complete the following information):
Additional context
It was working just find before this MR #141
The text was updated successfully, but these errors were encountered: