fix(modules-sdk): check if dependency is registered (#3620)

* fix: check if dependency is registered * changeset
medusajs · Mar 29, 2023 · 55e94d0 · 55e94d0
1 parent 8ddb395
commit 55e94d0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/ninety-crews-develop.md b/.changeset/ninety-crews-develop.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/modules-sdk": patch
+---
+
+Checks if dependency is registered before resolving it
diff --git a/packages/inventory/src/services/inventory.ts b/packages/inventory/src/services/inventory.ts
@@ -7,7 +7,6 @@ import {
  FilterableInventoryLevelProps,
  FilterableReservationItemProps,
  FindConfig,
- IEventBusService,
  IInventoryService,
  InventoryItemDTO,
  InventoryLevelDTO,
@@ -28,21 +27,19 @@ import ReservationItemService from "./reservation-item"
 
 type InjectedDependencies = {
  manager: EntityManager
- eventBusService: IEventBusService
  inventoryItemService: InventoryItemService
  inventoryLevelService: InventoryLevelService
  reservationItemService: ReservationItemService
 }
 export default class InventoryService implements IInventoryService {
  protected readonly manager_: EntityManager
- protected readonly eventBusService_: IEventBusService | undefined
+
  protected readonly inventoryItemService_: InventoryItemService
  protected readonly reservationItemService_: ReservationItemService
  protected readonly inventoryLevelService_: InventoryLevelService
 
  constructor(
  {
- eventBusService,
  manager,
  inventoryItemService,
  inventoryLevelService,
@@ -52,7 +49,6 @@ export default class InventoryService implements IInventoryService {
  moduleDeclaration?: InternalModuleDeclaration
  ) {
  this.manager_ = manager
- this.eventBusService_ = eventBusService
  this.inventoryItemService_ = inventoryItemService
  this.inventoryLevelService_ = inventoryLevelService
  this.reservationItemService_ = reservationItemService

diff --git a/packages/modules-sdk/src/loaders/utils/load-internal.ts b/packages/modules-sdk/src/loaders/utils/load-internal.ts
@@ -75,7 +75,11 @@ export async function loadInternalModule(
  for (const dependency of moduleDependencies) {
  localContainer.register(
  dependency,
- asFunction(() => container.resolve(dependency))
+ asFunction(() => {
+ return container.hasRegistration(dependency)
+ ? container.resolve(dependency)
+ : undefined
+ })
  )
  }
  }