Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modules-sdk): check if dependency is registered #3620

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:
It checks if module's dependency is registered before resolving the container. Otherwise return undefined

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner March 28, 2023 23:16
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 064cf64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@medusajs/modules-sdk Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/inventory Patch
medusa-plugin-algolia Patch
@medusajs/medusa Patch
@medusajs/stock-location Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 28, 2023 at 11:16PM (UTC)

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 55e94d0 into develop Mar 29, 2023
@olivermrbl olivermrbl deleted the fix/check-container-module-dependency branch March 29, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants