Skip to content

Commit

Permalink
fix(medusa): fix bug with parent not being saved correctly (#3534)
Browse files Browse the repository at this point in the history
What:

- Parent was being updated incorrectly because of a weird typeorm issue, making the rank pick up the wrong entity's rank. This PR fixes that issue by passing in an ID and letting the service take care of fetching the parent.

RESOLVES CORE-1274
  • Loading branch information
riqwan authored Mar 21, 2023
1 parent c328ec5 commit 7f2223b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/stupid-chefs-ring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/medusa": patch
---

fix(medusa): fix bug with parent not being saved correctly
6 changes: 3 additions & 3 deletions packages/medusa/src/commands/seed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,12 @@ const seed = async function ({ directory, migrate, seedFile }: SeedOptions) {

const createProductCategory = async (
parameters,
parentCategory: ProductCategory | null = null
parentCategoryId: string | null = null
) => {
// default to the categories being visible and public
parameters.is_active = parameters.is_active || true
parameters.is_internal = parameters.is_internal || false
parameters.parent_category = parentCategory || null
parameters.parent_category_id = parentCategoryId

const categoryChildren = parameters.category_children || []
delete parameters.category_children
Expand All @@ -229,7 +229,7 @@ const seed = async function ({ directory, migrate, seedFile }: SeedOptions) {

if (categoryChildren.length) {
for (const categoryChild of categoryChildren) {
await createProductCategory(categoryChild, category)
await createProductCategory(categoryChild, category.id)
}
}
}
Expand Down

0 comments on commit 7f2223b

Please sign in to comment.