Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): fix bug with parent not being saved correctly #3534

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 20, 2023

What:

  • Parent was being updated incorrectly because of a weird typeorm issue, making the rank pick up the wrong entity's rank. This PR fixes that issue by passing in an ID and letting the service take care of fetching the parent.

RESOLVES CORE-1274

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: 4393f12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 8:49AM (UTC)

@riqwan riqwan force-pushed the feat/medusa-seed-categories branch from f5e5c2c to 6f1c73d Compare March 20, 2023 23:32
@riqwan riqwan changed the title Feat/medusa seed categories fix(medusa): fix bug with parent not being saved correctly Mar 20, 2023
@riqwan riqwan marked this pull request as ready for review March 20, 2023 23:35
@riqwan riqwan requested a review from a team as a code owner March 20, 2023 23:35
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 7f2223b into develop Mar 21, 2023
@kodiakhq kodiakhq bot deleted the feat/medusa-seed-categories branch March 21, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants