Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #2614

Closed
wants to merge 2 commits into from
Closed

wip #2614

wants to merge 2 commits into from

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Nov 16, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

⚠️ No Changeset found

Latest commit: 64cf5a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srindom
Copy link
Collaborator Author

srindom commented Nov 16, 2022

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]

Latest commit: 3aa0827

@adrien2p
Copy link
Member

@srindom I inspired myself from your pr and included here 3cd151f I have also extracted the notion of redis into a separate cache service so that we don't import redis anymore in all places and instead we can use that service. The idea is that if we want to use something else to cache we can just change the service and it will be applied everywhere instead of having to change the entire code base. Also, it means that we could allow a user to replace the cache with his own if needed. wdyt?

@olivermrbl
Copy link
Contributor

I have also extracted the notion of redis into a separate cache service

Added a comment in your other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants