-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Performance improvements of Carts domain #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 17c90c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
force-pushed
the
feat/create-cart-perf-improvement
branch
from
November 22, 2022 15:50
eb8ff59
to
0d84397
Compare
olivermrbl
reviewed
Nov 23, 2022
Closed
adrien2p
force-pushed
the
feat/create-cart-perf-improvement
branch
2 times, most recently
from
November 23, 2022 10:29
f7e7338
to
6f0137a
Compare
adrien2p
force-pushed
the
feat/create-cart-perf-improvement
branch
3 times, most recently
from
November 23, 2022 16:25
c4a65ff
to
5656f43
Compare
adrien2p
requested review from
olivermrbl,
carlos-r-l-rodrigues,
patrick-medusajs and
pKorsholm
November 23, 2022 17:23
srindom
reviewed
Nov 23, 2022
adrien2p
requested review from
srindom,
carlos-r-l-rodrigues and
olivermrbl
and removed request for
srindom,
carlos-r-l-rodrigues,
olivermrbl,
pKorsholm and
patrick-medusajs
November 24, 2022 11:46
adrien2p
force-pushed
the
feat/create-cart-perf-improvement
branch
from
December 7, 2022 08:53
426d8c6
to
9062b8e
Compare
olivermrbl
changed the title
Feat/create cart perf improvement
feat(medusa): Performance improvements of Carts domain
Dec 7, 2022
olivermrbl
reviewed
Dec 7, 2022
olivermrbl
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
adrien2p
force-pushed
the
feat/create-cart-perf-improvement
branch
from
December 7, 2022 09:36
a00fe15
to
be706df
Compare
I ve closed and reopened the pr to trigger the pipeline to run again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I have created a new method on the cart service which is
addLineItems
, allowing a user to add one or multiple items in an optimized way. Also updated thegenerate
method from the line item service which now also accept a object data or a collection of data which. Various places have been optimized and cache support has been added to the price selection strategy.The overall optimization allows to reach another 9000% improvement in the response time as a median (Creating a cart with 6 items):
FIXES CORE-722