#CHT-151. Handle ECONN_REFUSED upon connection to chatd / presenced #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v2.3.4
#16247. Chat room title nullability (Obj-C)
Release/v2.3.5
Upon wsConnect fails we need to re-fetch a fresh URL, because we can't detect if connection has been refused by server or we don't have connectivity. If host of fresh URL does not match with the host that we have stored in cache, we need to abort the retry controller if any, update DNS cache and retry a new connection attempt.
Upon wsConnect fails we need to re-fetch a fresh URL, because we can't detect if connection has been refused by server or we don't have connectivity. If host of fresh URL does not match with the host that we have stored in cache, we need to abort the retry controller if any, update DNS cache and retry a new connection attempt.
The code in `wsCloseCb()` is already executed by the subsequent call to `retryPendingConnections(true)`. The code in `retryPendingConnection()` is already executed by `setState(kDisconnected)`
Do not create temporary object and ensure it's an update (not an addition).
|
karere-crossandroid-PRs SUCCEDED (46) 👍 |
sergiohs84
approved these changes
Aug 28, 2020
|
karere-crossandroid-PRs SUCCEDED (49) 👍 |
|
karere-native-linux-PRs SUCCEDED (1554) 👍 |
|
karere-native-linux-PRs SUCCEDED (1557) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.