fix: High contrast mode hover style icon fixes in react-button components #28156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 14804fe31e9f34d3f21998dcb386fdddd23f9839 (build) |
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 10 | 11 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 590 | 596 | 5000 | |
| Button | mount | 288 | 290 | 5000 | |
| Field | mount | 1027 | 1054 | 5000 | |
| FluentProvider | mount | 638 | 632 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 67 | 74 | 10 | |
| InfoButton | mount | 10 | 11 | 5000 | Possible regression |
| MakeStyles | mount | 843 | 849 | 50000 | |
| Persona | mount | 1652 | 1596 | 5000 | |
| SpinButton | mount | 1298 | 1291 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e6b36aa:
|
🕵 fluentuiv9 No visual regressions between this PR and main |
khmakoto
changed the title
khmakoto
approved these changes
Jun 6, 2023
packages/react-components/react-button/src/components/Button/useButtonStyles.styles.ts
Outdated
Show resolved
Hide resolved
|
/azp run Fluent UI React - PR and CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
those bundle size increases are not looking good. can we update this branch with latest master to check if it's only stale data regression or actual size increase ? if it's really a size increase it would be good to investigate first what causes almost 2kb bump - that's quite a lot for this change. |
smhigley
reviewed
Jun 7, 2023
packages/react-components/react-button/src/components/Button/useButtonStyles.styles.ts
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
smhigley
approved these changes
Jul 20, 2023
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2023
* master: (32 commits) chore: remove @fluentui/bundle-size (microsoft#28601) Breadcrumb UI adjustments (microsoft#28578) feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561) perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597) Table/DataGrid: keyboard resizing improvements (microsoft#28493) docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611) chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590) feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577) add vr test to react-tags (microsoft#28484) applying package updates chore: migrate to monosize (microsoft#26826) fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599) fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162) feat: implements selection (microsoft#28497) bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579) Fix empty CSS creation (microsoft#28566) chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575) applying package updates fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156) SplitButton: updated border right token for primary variant (microsoft#28555) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the contrast of the icon on subtle buttons and text on transparent buttons in high contrast mode.
Before:
After:
Also corrects the color of the secondary text for CompoundButton.
Before:
After:
Removes the high contrast MenuButton bug that causes icons to change colors when the menu is open.
Before:
After:
Removes the high contrast ToggleButton bug that caused the Subtle and Transparent variants to have low contrast icons.
Before:
After:
