Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements selection #28497

Merged
merged 10 commits into from
Jul 20, 2023
Merged

feat: implements selection #28497

merged 10 commits into from
Jul 20, 2023

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jul 11, 2023 •
edited
Loading

New Behavior

  1. adds selection implementation that properly works with Flat tree
  2. adds stories for single and multiselect

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 11, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 11, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80bafa9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-selection branch from 0b79745 to a628154 Compare July 12, 2023 04:08
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 67.576 kB
18.225 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 213.081 kB
59.115 kB
react-components
react-components: FluentProvider & webLightTheme		 36.409 kB
12.003 kB
react-portal-compat
PortalCompatProvider		 6.48 kB
2.203 kB
🤖 This report was generated against ff9dc9f04b3d5bcb7938def03d12004f5a1eb373

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 12, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 584 578 5000
Button mount 299 300 5000
Field mount 1043 1041 5000
FluentProvider mount 644 637 5000
FluentProviderWithTheme mount 83 82 10
FluentProviderWithTheme virtual-rerender 81 73 10
FluentProviderWithTheme virtual-rerender-with-unmount 81 77 10
InfoButton mount 15 14 5000
MakeStyles mount 847 855 50000
Persona mount 1661 1612 5000
SpinButton mount 1321 1294 5000

@size-auditor
Copy link

size-auditor bot commented Jul 12, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ff9dc9f04b3d5bcb7938def03d12004f5a1eb373 (build)

@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-selection branch from cc923d7 to 95f2946 Compare July 13, 2023 12:34
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-selection branch from 95f2946 to 1782eab Compare July 13, 2023 12:37
@bsunderhus bsunderhus marked this pull request as ready for review July 17, 2023 17:22
@bsunderhus bsunderhus requested a review from a team as a code owner July 17, 2023 17:22
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-selection branch from 01d8d07 to ae57e97 Compare July 20, 2023 10:16
@bsunderhus bsunderhus merged commit f5b6134 into microsoft:master Jul 20, 2023
21 checks passed
@bsunderhus bsunderhus deleted the react-tree/feat--implements-selection branch July 20, 2023 12:21
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jul 25, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
c6c9711 
* master: (32 commits)
  chore: remove @fluentui/bundle-size (microsoft#28601)
  Breadcrumb UI adjustments (microsoft#28578)
  feat(tools): re-generate react-components.api.md when preparing 1st stable release (microsoft#28561)
  perf(tools): make dependency-mismatch execution 90% faster and ignore */>=9.0.0-alpha versions (microsoft#28597)
  Table/DataGrid: keyboard resizing improvements (microsoft#28493)
  docs(react-tooltip): Add info icon + tooltip story to Tooltip stories (microsoft#28611)
  chore: Updating @fluentui/react-icons to version 2.0.207 (microsoft#28590)
  feat: allSelectedRows and someSelectedRows should be more reliable (microsoft#28577)
  add vr test to react-tags (microsoft#28484)
  applying package updates
  chore: migrate to monosize (microsoft#26826)
  fix(react-conformance): add @swc/helpers to deps instead of tslib as we use swc for transpilation (microsoft#28599)
  fix: MenuItem content should be spaced 12px from the boundary (microsoft#28162)
  feat: implements selection (microsoft#28497)
  bugfix: moves handleBackdropClick from defaultProps to an override (microsoft#28579)
  Fix empty CSS creation (microsoft#28566)
  chore: replace plop with nx within create-* aliases in root package.json (microsoft#28575)
  applying package updates
  fix: High contrast mode hover style icon fixes in react-button components (microsoft#28156)
  SplitButton: updated border right token for primary variant (microsoft#28555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petdud petdud petdud left review comments

@ling1726 ling1726 ling1726 approved these changes

Assignees

@bsunderhus bsunderhus

Labels
Component: Tree Fluent UI react-components (v9)
Projects
None yet
Milestone
July Project Cycle Q3 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@bsunderhus @fabricteam @petdud @ling1726 @GeoffCoxMSFT