test: unskip passing setContent test #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
changed the title
|
It was just skipped for being flaky, so I guess we can't do that! |
|
If it's flaky, we should fix it, not skip. It passed a few iterations for me. |
dgozman
reviewed
Jan 25, 2020
| @@ -534,7 +534,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF | |||
| const result = await page.content(); | |||
| expect(result).toBe(expectedOutput); | |||
| }); | |||
| it.skip(FFOX || WEBKIT)('should not confuse with previous navigation', async({page, server}) => { | |||
| it('should not confuse with previous navigation', async({page, server}) => { | |||
There was a problem hiding this comment.
This reliably does not work with .repeat(100) and -j 10 on my mac. I spent two hours trying to make it work on WebKit, and it seems like we don't always get load event after setContent. I'll keep digging.
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
…icrosoft#650) This reverts commit aadf7d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.