feat(launcher): gracefully close browser on sigint #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated, PTAL. |
|
|
||
| let gracefullyClosing = false; | ||
| async function gracefullyClose(): Promise<void> { | ||
| // We keep listeners until we are done, to handle 'exit' and 'SIGINT' while |
There was a problem hiding this comment.
Are we calling gracefullyClose on exit? I think this comment is lying to me.
| const {describe, xdescribe, fdescribe} = testRunner; | ||
| const {it, fit, xit, dit} = testRunner; | ||
| const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; | ||
|
|
||
| async function testSignal(action) { | ||
| const options = Object.assign({}, defaultBrowserOptions, { |
There was a problem hiding this comment.
nit: If you want to be fancy, you can do
{...defaultBrowserOptions, dumpio: false, webSocket: true} instead of Object.assign. Up to you :)
| res.stdout.on('data', data => { | ||
| output += data; | ||
| // Uncomment to debug these tests. | ||
| // console.log(data.toString()); |
There was a problem hiding this comment.
For your consideration:
Suggested change
| // console.log(data.toString()); | |
| if (defaultBrowserOptions.dumpio) | |
| console.log(data.toString()); |
JoelEinbinder
approved these changes
Jan 27, 2020
|
Tested on my computer, seems to work fine. |
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
…icrosoft#650) This reverts commit aadf7d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.