Bumps Node to 14 #43
Merged
Bumps Node to 14 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
requested review from
eddynaka,
GabeDeBacker,
jeffersonking,
michaelcfanning and
rwjblue
as code owners
|
Hi @scalvert , I think we should also remove the tests for node 12 since we will mark as deprecated, right? |
|
Yep. I'm just updating that now! |
|
Another thing that came to my mind and a question: is the changelog automatically made? if not, should we include in that since this is a breaking change? |
…node version test matrix
eddynaka
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Node LTS documentation, Node 12 is scheduled for EOL on 2022-04-30. This bump updates the version of node to 14 in:
eslint-formatter-sarifjest-sarifsarif-builderMerging this change would precipitate the need to publish a major version increment for the 3 packages.