Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps Node to 14 #43

Merged
merged 4 commits into from
Mar 31, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
matrix:
os: [windows, ubuntu]
node-version: [12.x, 14.x, 15.x]
node-version: [14.x, 15.x, 16.x, 17.x]

steps:
- uses: actions/checkout@v2
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/eslint-sarif-test.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: ESlint sarif formatter test workflow
on:
pull_request:
branches:
branches:
- main
paths:
- 'packages/eslint-formatter-sarif/**'
Expand All @@ -18,23 +18,23 @@ jobs:
run: |
npm install eslint
npm install @microsoft/sarif-multitool

- name: Install ESLint SARIF formatter dependencies
run: npm install

- name: Run local eslint + sarif formatter
run: npx eslint ./packages/eslint-formatter-sarif
--ext .js,.jsx,.ts,.tsx
--ext .js,.jsx,.ts,.tsx
--format ./packages/eslint-formatter-sarif/sarif.js
--output-file eslint-results.sarif
continue-on-error: true

- name: Upload eslint results as artifact
uses: actions/upload-artifact@v2
with:
name: eslint-results
path: eslint-results.sarif

- name: Validate sarif file
run: npx @microsoft/sarif-multitool validate eslint-results.sarif

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"npm": false
},
"volta": {
"node": "12.21.0",
"node": "14.19.1",
"npm": "7.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-formatter-sarif/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"eslint sarif"
],
"engines": {
"node": ">= 12.11.*"
"node": ">= 14"
},
"files": [
"sarif.js"
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-sarif/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"jest-sarif"
],
"engines": {
"node": ">= 12.11.*"
"node": ">= 14"
},
"files": [
"/lib"
Expand Down
2 changes: 1 addition & 1 deletion packages/sarif-builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"test": "jest --passWithNoTests"
},
"engines": {
"node": ">= 12.11.*"
"node": ">= 14"
}
}