Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should show an error dialog for outdated MacType versions #17140

Closed
lhecker opened this issue Apr 26, 2024 · 1 comment · Fixed by #17369
Closed

We should show an error dialog for outdated MacType versions #17140

lhecker opened this issue Apr 26, 2024 · 1 comment · Fixed by #17369
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@lhecker
Copy link
Member

lhecker commented Apr 26, 2024

AtlasEngine only works with v1.2023.5.31 and later. We have two options:

  • Show an error bar similar to how we do it for the text input service
  • Show a classic error dialog and refuse to start

I personally prefer the latter as users should definitely update MacType ASAP'st. It may potentially destabilize the rest of the OS too after all.
@lhecker lhecker added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Apr 26, 2024
@lhecker lhecker added this to the Terminal v1.21 milestone Apr 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 26, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@lhecker lhecker modified the milestones: Terminal v1.21, Terminal v1.22 May 1, 2024
@zadjii-msft
Copy link
Member

oh hey we merged this in #17369

@zadjii-msft zadjii-msft added the In-PR This issue has a related PR label Jun 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 11, 2024
@zadjii-msft zadjii-msft linked a pull request Jun 11, 2024 that will close this issue
Warn when using old MacType versions #17369
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

Warn when using old MacType versions microsoft/terminal
3 participants
@lhecker @carlos-zamora @zadjii-msft