Warn when using old MacType versions #17369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Area-Rendering
lhecker
commented
Jun 5, 2024
Comment on lines
221
to
222
| <value>Your version of MacType is incompatible with this application. Please update to version 2023.5.31 or later.</value> | ||
| <comment>{Locked="2023.5.31"}</comment> |
There was a problem hiding this comment.
If you have a better wording in mind, please let me know!
|
Do we want to service this? |
yes but we need to wait for localization |
DHowett
approved these changes
Jun 5, 2024
Co-authored-by: Dustin L. Howett <[email protected]>
zadjii-msft
approved these changes
Jun 5, 2024
|
i love this |
DHowett
approved these changes
Jun 5, 2024
DHowett
added a commit
that referenced
this pull request
Jun 7, 2024
This adds a check for whether MacType is injected and whether it's a known bad version (pre-2023). In that case we avoid calling the known faulty `ID2D1Device4` interface. We could avoid it in general to fix the issue without a warning (it's only a very mild optimization), but on the other hand, the bug that MacType has is a very serious one and it's probably better overall to suggest users to update. See: snowie2000/mactype#938 * MacType 2021.1-RC1 results in a warning and no crash ✅ * MacType 2023.5.31 results in no warning ✅ --------- Co-authored-by: Dustin L. Howett <[email protected]> (cherry picked from commit 9317d42) Service-Card-Id: 92687128 Service-Version: 1.20
DHowett
added a commit
that referenced
this pull request
Jun 7, 2024
This adds a check for whether MacType is injected and whether it's a known bad version (pre-2023). In that case we avoid calling the known faulty `ID2D1Device4` interface. We could avoid it in general to fix the issue without a warning (it's only a very mild optimization), but on the other hand, the bug that MacType has is a very serious one and it's probably better overall to suggest users to update. See: snowie2000/mactype#938 ## Validation Steps Performed * MacType 2021.1-RC1 results in a warning and no crash ✅ * MacType 2023.5.31 results in no warning ✅ --------- Co-authored-by: Dustin L. Howett <[email protected]> (cherry picked from commit 9317d42) Service-Card-Id: 92687129 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Jun 10, 2024
DHowett
pushed a commit
that referenced
this pull request
Jun 20, 2024
DHowett
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for whether MacType is injected and whether it's
a known bad version (pre-2023). In that case we avoid calling the
known faulty
ID2D1Device4interface. We could avoid it in general tofix the issue without a warning (it's only a very mild optimization),
but on the other hand, the bug that MacType has is a very serious one
and it's probably better overall to suggest users to update.
See: snowie2000/mactype#938
Validation Steps Performed