Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - Chunk Selection #1933

Closed
carlos-zamora opened this issue Jul 11, 2019 · 1 comment · Fixed by #2184
Closed

Feature Request - Chunk Selection #1933

carlos-zamora opened this issue Jul 11, 2019 · 1 comment · Fixed by #2184
Assignees
@carlos-zamora
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal 1908.1

Comments

@carlos-zamora
Copy link
Member

Summary of the new feature/enhancement

Double-/Triple- click selection should expand to the next delimiter when dragging a held mouse button.

Proposed technical implementation details (optional)

Most of this work should be in a combination of TermControl and Terminal. I've already been working on this in a separate branch.
@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Product-Terminal The new Windows Terminal. labels Jul 11, 2019
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone Jul 11, 2019
@carlos-zamora carlos-zamora self-assigned this Jul 11, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2019
@carlos-zamora carlos-zamora mentioned this issue Jul 31, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 31, 2019
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Aug 14, 2019
DHowett-MSFT pushed a commit that referenced this issue Aug 14, 2019
@carlos-zamora @DHowett
Chunk Selection Expansion for Double/Triple Click Selection (#2184)
1f41fd3 
Double/Triple click create a selection expanding beyond one cell. This PR makes it so that when you're dragging your mouse to expand the selection, you expand to the next delimiter defined by double/triple click.

So, double click expands by doubleClickDelimiter ranges. Triple click expands by line.

When you double/triple click, a word/line is selected. When you drag, that word/line will remain selected after the expansion occurs.

Closes #1933 

## Details
Rather than resizing the selection when the mouse event occurs, I figured I'd do what I did with wide glyph selection: expand at render time.

We needed an enum `multiClickSelectionMode` to keep track of which expansion mode we're in.

Minor modifications to `_ExpandDoubleClickSelection*(COORD)` had to be made so that we can re-use them. 

Actual expansion occurs in `_GetSelectionRects()`

## Validation Steps Performed
- generic double click test
  - `dir` or `ls`
  - double click a word
  - drag up
  - Works! ✔
- double click on delimiter test
  - `dir` or `ls`
  - double click a word delimiter (i.e.: space between words)
  - drag up
  - Works! ✔
- generic triple click test
  - `dir` or `ls`
  - triple click a line
  - drag up
  - Works! ✔
- ALT + double click test
  - `dir` or `ls`
  - hold ALT
  - double click a word
  - drag up
  - Works! ✔

repeat above tests in following scenarios:
- when at top of scrollback
- drag down instead of up
@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2184, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal 1908.1
Development

Successfully merging a pull request may close this issue.

Chunk Selection Expansion for Double/Triple Click Selection microsoft/terminal
1 participant
@carlos-zamora