Chunk Selection Expansion for Double/Triple Click Selection

[carlos-zamora]

Summary of the Pull Request

Double/Triple click create a selection expanding beyond one cell. This PR makes it so that when you're dragging your mouse to expand the selection, you expand to the next delimiter defined by double/triple click.

So, double click expands by doubleClickDelimiter ranges. Triple click expands by line.

When you double/triple click, a word/line is selected. When you drag, that word/line will remain selected after the expansion occurs.

References

PR Checklist

• Closes Feature Request - Chunk Selection #1933
• CLA signed.
• Tests added/passed not necessary
• Requires documentation to be updated
• I am a core contributor

Detailed Description of the Pull Request / Additional comments

Rather than resizing the selection when the mouse event occurs, I figured I'd do what I did with wide glyph selection: expand at render time.

We needed an enum multiClickSelectionMode to keep track of which expansion mode we're in.

Minor modifications to _ExpandDoubleClickSelection*(COORD) had to be made so that we can re-use them.

Actual expansion occurs in _GetSelectionRects()

Validation Steps Performed

• generic double click test
  • dir or ls
  • double click a word
  • drag up
  • Works! ✔
• double click on delimiter test
  • dir or ls
  • double click a word delimiter (i.e.: space between words)
  • drag up
  • Works! ✔
• generic triple click test
  • dir or ls
  • triple click a line
  • drag up
  • Works! ✔
• ALT + double click test
  • dir or ls
  • hold ALT
  • double click a word
  • drag up
  • Works! ✔

repeat above tests in following scenarios:

• when at top of scrollback
• drag down instead of up

[carlos-zamora]

so, this little section here: _selectionAnchor != _endSelectionPosition is something that I can call a function in in #2152

I'll be sure to clean it up if (a) that PR goes in first or (b) after I do a general cleanup to address #1327

[zadjii-msft]

I think I'd really love to see some extra tests added for this in the TerminalCore tests.

[carlos-zamora]

BUG REPORT:
- double click
- drag to leftmost highlighted cell

Expected Behavior: entire word stays highlighted

Actual Behavior: selection changes to a 1x1 cell selection

#Resolved

[DHowett-MSFT]

y new except

[carlos-zamora]

Theoretically, we should never hit this case. But, if somebody somehow did a double click OUTSIDE of the terminal, I think it makes sense to clamp it to the nearest valid buffer cell. So how does this sound?

positionWithOffsets.X = std::clamp(viewportPos.X, static_cast<SHORT>(0), _buffer->GetSize().RightInclusive());
positionWithOffsets.Y = std::clamp(viewportPos.Y, static_cast<SHORT>(0), _buffer->GetSize().BottomInclusive());

Note that this is explicitly should not be clamped to the viewport to allow for selections outside of the region we can see. This mainly affects scroll interactions (i.e.: auto scroll, scrolling into an existing selection, etc...).

[zadjii-msft]

Double/Triple Click testing

[DHowett-MSFT]

SA is out of disk space.

[ghost]

🎉Windows Terminal Preview v0.4.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download