-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double and Triple Click Selection #1197
Conversation
Bugfix (double click after scrolling would go out of bounds)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one odd thing with the triple click check that I want to see your answer to before signing off.
Once #1273 gets merged in, I'm gonna do a bit of refactoring too. I want to move most/all of the changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please fix the seconds/milliseconds comment mismatch before merging.
Import System double click time rename `_DoubleClickDelimiterCheck`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
🎉 Handy links: |
Summary of the Pull Request
Initial double click selection works. So a double click will make a selection within some preset delimiters (' ', '/' '\'). The left side excludes the delimiter. The right side includes it.
Initial triple click selection works. Selects the entire line.
The following known issues will be implemented in separate PRs.
Known Issues:
References
#1084 Screenshot Selection: one step closer to this. Now just need to create it and attach it as a configurable option to triple click
#988 Double Click Selection: needs ChunkSelection + Settings before completion
#989 Triple Click Selection: needs ChunkSelection + Settings before completion
PR Checklist
Detailed Description of the Pull Request / Additional comments
TermControl Changes
Terminal Changes
Validation Steps Performed
You can actually do most with the header on startup :).