Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Double Click should select delimiter runs #2206

Closed
carlos-zamora opened this issue Aug 2, 2019 · 2 comments · Fixed by #2511
Closed

Bug Report: Double Click should select delimiter runs #2206

carlos-zamora opened this issue Aug 2, 2019 · 2 comments · Fixed by #2511
Assignees
@carlos-zamora
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1909

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Aug 2, 2019 •
edited by DHowett-MSFT
Loading

Environment

Caused by #1197.
More apparent in #2184.

Steps to reproduce

  1. ensure double click delimiters includes " "
  2. double click on empty line

Expected behavior

Selection should encompass entire line.

Actual behavior

Selection encompasses one cell.

Additional Info

This one's on me. Idk why I thought that double clicking a delimiter should only select the delimiter itself. That's not useful.

Instead, the selection seems like it should expand to the first non-delimiter in either direction (exclusive range). For example,
O is non-delimiter
X is delimiter
Double clicking on any of the X would result in the following selection (denoted by [ and ])
OOOXXXXXXOOO
OOO[XXXXXX]OOO
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 2, 2019
@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Help Wanted We encourage anyone to jump in on these. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 2, 2019
@carlos-zamora carlos-zamora added this to the Terminal 1908.1 milestone Aug 2, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 8, 2019
Closed
@DHowett-MSFT
Copy link
Contributor

From #2353

Not sure if I'll be able to get to this one on time. I'm hoping that the PRs referenced above provide enough guidance to get started. Feel free to tackle this on (just be sure to mention that here).

@carlos-zamora carlos-zamora self-assigned this Aug 22, 2019
@carlos-zamora carlos-zamora removed the Help Wanted We encourage anyone to jump in on these. label Aug 22, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 22, 2019
Merged
7 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 22, 2019
DHowett-MSFT pushed a commit that referenced this issue Sep 17, 2019
@carlos-zamora @DHowett
Selection Code Cleanup + Double Click Delimiter Runs (#2511)
4217bed 
* Test: out of bounds selection
* Clean up Selection code:
- selectionVerticalOffset
- proper return values (const)
- Break up GetSelectionRects()

* Fix Delimiter Text Runs (#2552)

* Added helper method and some log comments throughout tests

Closes #1327.
Closes #2261.
Closes #2206.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 17, 2019
@ghost
Copy link

ghost commented Sep 24, 2019

🎉This issue was addressed in #2511, which has now been successfully released as Windows Terminal Preview v0.5.2661.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1909
Development

Successfully merging a pull request may close this issue.

Selection Code Cleanup and Double Click Delimiter Runs microsoft/terminal
2 participants
@carlos-zamora @DHowett-MSFT