Dismiss the snippet preview when there is no suggestions #17777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty obvious in retrospect. If there's no results, then we need to preview _nothing_ to make sure that we clear out any old previews. Closes #17773
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
carlos-zamora
approved these changes
Aug 22, 2024
Co-authored-by: Carlos Zamora <[email protected]>
DHowett
approved these changes
Aug 22, 2024
carlos-zamora
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty obvious in retrospect. If there's no results, then we need to preview
nothing to make sure that we clear out any old previews.
Closes #17773
Additionally, while I was here:
I realized why it seems like the selected item is so wacky when you first open the sxnui:
Alas, that second part is... shockingly bodgy.
(you can review this as two separate commits for sanity's sake)