Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss the snippet preview when there is no suggestions #17777

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Dismiss the snippet preview when there is no suggestions #17777

merged 3 commits into from
Aug 23, 2024

Commits on Aug 22, 2024

  1. Dismiss the snippet preview when there is no suggestions 

    Pretty obvious in retrospect. If there's no results, then we need to preview
_nothing_ to make sure that we clear out any old previews.

Closes #17773
    @zadjii-msft
    zadjii-msft committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6aff623 View commit details
    Browse the repository at this point in the history

  2. 'it should be easy to scroll to the right item'

    @zadjii-msft
    zadjii-msft committed Aug 22, 2024
    1 Configuration menu
    Copy the full SHA
    bd6c111 View commit details
    Browse the repository at this point in the history

  3. Update src/cascadia/TerminalApp/SuggestionsControl.cpp 

    Co-authored-by: Carlos Zamora <[email protected]>
    @DHowett @carlos-zamora
    DHowett and carlos-zamora authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0ef0b0f View commit details
    Browse the repository at this point in the history