-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap-vcpkg.bat broken on vc2015 AGAIN!!! #12220
Comments
Confirmed, @ras0219 @ras0219-msft could you please take a look? Thanks. |
Not trying to be negative but constructive - I really appreciate and like vcpkg. Having issues like this one and #12062 where core functionality breaks make it into the main vcpkg repo are worrying. Users use vcpkg by cloning the main repo and then doing their work. I'm super excited to use vcpkg and have moved many of my dependencies to build via it instead of building myself by hand. But breaks like these make me second-guess that decision. I really like several of the features on the vcpkg roadmap. They provide for some key functionality that will make vcpkg even more useful. Is there anything planned to improve the stability of the core vcpkg so that breaks like these don't happen so often? Happy to open a new issue if that's best to have a discussion about what could help improve vcpkg in this respect. Thanks! |
Thank you for the constructive feedback, and glad you're getting so much use out of vcpkg! We're aware of the recent instabilities and are actively working to improve the situation. For this issue (#12220), We're investigating distributing prebuilt binaries for vcpkg, which will enable us to decouple the awesome new C++ features we want to use in the tool from the user environments we want to support. For #12062, this looks like a solid case of us having insufficient test coverage for our feature set. We're actively working on making this situation better by consciously introducing test coverage at a faster rate than we're adding features, however we unfortunately haven't gotten to every existing feature yet. We would love PRs that add tests covering real-world use scenarios -- we've recently introduced a place[1] for end-to-end testing that would exactly cover #12062. Finally, we strongly recommend that for all production scenarios you pin the specific vcpkg commit you are using. This also pins library versions, so you can manage changes on your own terms in your dev environment instead of your stable CI. This is most easily done with git submodules (assuming you're using git). [1] https:/microsoft/vcpkg/blob/master/scripts/azure-pipelines/end-to-end-tests.ps1 |
Awesome. Thanks for responding so quickly. Prebuilt binaries sound like a promising solution for this bug. For the end-to-end testing, I've never done Azure pipeline stuff. Am I correct in assuming that I basically can assume I've got a dev-like environment with different VS versions installed at my disposal and could then try building a simple project that depends on something like x64-windows-static ? Is there a good way to simulate locally or remotely if I want to try writing such a test? The vcpkg commit is a good point. Thank you for making it. It might be worth having in the main readme. (In hindsight, I probably should've realized that, but it hadn't occurred to me.) I'm more a git subrepo than submodule fan, but either option works for this. Again, thanks for the quick response and great answers/pointers. Much appreciated. |
) Fixes #12220 Co-authored-by: Robert Schumacher <[email protected]>
…rosoft#12242) Fixes microsoft#12220 Co-authored-by: Robert Schumacher <[email protected]>
Is prebuilt binaries available now? |
Yes, prebuilt binaries are now used when you run |
Describe the bug
bootstrap-vcpkg.bat fails on vc2015 again, it just got fixed a few days ago by getting rid of new language features, and now this...
Environment
To Reproduce
Steps to reproduce the behavior:
before trying to add this manifest thingy, things used to work.
The offending commit is:
[vcpkg manifest] Manifest Implementation ([vcpkg manifest] Manifest Implementation #11757)
1d8f0ac
Expected behavior
bootstrap creates vcpkg.exe
Failure logs
Additional context
The offending commit is:
[vcpkg manifest] Manifest Implementation (#11757)
1d8f0ac
The text was updated successfully, but these errors were encountered: