Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Remove use of std::variant and std::visit to fix VS2015. #12242

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

ras0219
Copy link
Contributor

@ras0219 ras0219 commented Jul 3, 2020

Fixes #12220. Additionally, the v140 toolset should be added to the CI infrastructure so we can avoid breakages in the future, however we should not hold back this hotfix waiting for a new CI rollout.

@ras0219 ras0219 force-pushed the dev/roschuma/vs2015 branch 2 times, most recently from c9f6de5 to 558ff96 Compare July 3, 2020 03:59
@ras0219 ras0219 marked this pull request as draft July 3, 2020 04:19
@ras0219 ras0219 marked this pull request as ready for review July 3, 2020 04:49
@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Jul 3, 2020
@strega-nil strega-nil merged commit e82e56f into microsoft:master Jul 6, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap-vcpkg.bat broken on vc2015 AGAIN!!!
5 participants