Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Resolve link error to date::locate_zone #7591

Closed
degski opened this issue Aug 8, 2019 · 1 comment
Closed

[date] Resolve link error to date::locate_zone #7591

degski opened this issue Aug 8, 2019 · 1 comment
Assignees
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@degski
Copy link

degski commented Aug 8, 2019

I don't know what the solution is, but HowardHinnant/date#398 is the problem.

EDIT: It looks like the port's CMakeLists.txt file does not deal with compiling for C++17 (std is set to C++11), then thereafter (when called), from a program compiled with C++17, now all of a sudden std::string_view is defined, but that overload is not available.

I've for now plugged the file for my purposes, but it should obviously be done correctly (I'm not qualified).

CMakeLists.txt

@degski degski added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 8, 2019
@PhoebeHui PhoebeHui self-assigned this Nov 27, 2019
@MonicaLiu0311
Copy link
Contributor

At present, the upstream has set C++17 in CMakeLists. I successfully build and link to my library after trying it locally.

Fixed by upstream#492, #11968.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

No branches or pull requests

4 participants