Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date] Update to 3.0.0 #11968

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[date] Update to 3.0.0 #11968

merged 1 commit into from
Jun 23, 2020

Conversation

JackBoosY
Copy link
Contributor

Update to version 3.0.0 to fix issue #9082.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jun 16, 2020
@JackBoosY
Copy link
Contributor Author

Hi @acgetchell, could you test this PR?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review June 16, 2020 12:43
@JackBoosY JackBoosY requested a review from PhoebeHui June 16, 2020 12:44
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2020
@JackBoosY JackBoosY linked an issue Jun 17, 2020 that may be closed by this pull request
@vicroms vicroms merged commit 2c280ee into microsoft:master Jun 23, 2020
@JackBoosY JackBoosY deleted the dev/jack/9082 branch June 24, 2020 05:51
@yamcenutzer
Copy link

Question:
after updating to 3.0 date offers to use date::tz in cmake as link_library, but that doesn't work. You need to use date::date-tz.
Is that another cmake bug (aliases broken) or is there another way continuing to use date::tz in a cosuming cmake project ?

Thx,

@JackBoosY
Copy link
Contributor Author

@yamcenutzer I think that because the official changed the target name, we should use the new name.

@yamcenutzer
Copy link

yamcenutzer commented Jul 3, 2020

yes, ok,
I was just curious about thuis ALIAS feature of cmake. seems kinda useless if not actually misleading
to me now

@acgetchell
Copy link

acgetchell commented Jul 31, 2020

When I try to use this, with the suggested date::date-tz I get:

CMake Error at /Users/adam/vcpkg/scripts/buildsystems/vcpkg.cmake:333 (_add_executable):
  Target "initialize" links to target "Threads::Threads" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:80 (add_executable)

This goes away if I remove date::date-tz

But then just using date::date is insufficient:

====================[ Build | CDT_test | Debug ]================================
"/Users/adam/Library/Application Support/JetBrains/Toolbox/apps/CLion/ch-0/202.6397.106/CLion.app/Contents/bin/cmake/mac/bin/cmake" --build /Users/adam/CDT-plusplus/cmake-build-debug --target CDT_test
[1/1] Linking CXX executable tests/CDT_test
FAILED: tests/CDT_test 
: && /Library/Developer/CommandLineTools/usr/bin/c++  -g -flto=thin -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names  tests/CMakeFiles/CDT_test.dir/main.cpp.o tests/CMakeFiles/CDT_test.dir/Apply_move_test.cpp.o tests/CMakeFiles/CDT_test.dir/Ergodic_moves_3_test.cpp.o tests/CMakeFiles/CDT_test.dir/Foliated_triangulation_test.cpp.o tests/CMakeFiles/CDT_test.dir/Function_ref_test.cpp.o tests/CMakeFiles/CDT_test.dir/Geometry_test.cpp.o tests/CMakeFiles/CDT_test.dir/Manifold_test.cpp.o tests/CMakeFiles/CDT_test.dir/Move_command_test.cpp.o tests/CMakeFiles/CDT_test.dir/Move_strategies_test.cpp.o tests/CMakeFiles/CDT_test.dir/S3Action_test.cpp.o tests/CMakeFiles/CDT_test.dir/Sphere_test.cpp.o tests/CMakeFiles/CDT_test.dir/Tetrahedron_test.cpp.o tests/CMakeFiles/CDT_test.dir/Torus_test.cpp.o tests/CMakeFiles/CDT_test.dir/Utilities_test.cpp.o tests/CMakeFiles/CDT_test.dir/Vertex_test.cpp.o tests/CMakeFiles/CDT_test.dir/Settings_test.cpp.o  -o tests/CDT_test  /Users/adam/vcpkg/installed/x64-osx/lib/libtbb.a  /Users/adam/vcpkg/installed/x64-osx/debug/lib/libmpfr.a  /Users/adam/vcpkg/installed/x64-osx/debug/lib/libgmp.a && :
undef: __ZNK4date9time_zone13get_info_implENSt3__16chrono10time_pointINS2_12system_clockENS2_8durationIxNS1_5ratioILl1ELl1EEEEEEE
undef: __ZN4date12current_zoneEv
Undefined symbols for architecture x86_64:
  "date::time_zone::get_info_impl(std::__1::chrono::time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1l> > >) const", referenced from:
      date::sys_info date::time_zone::get_info<std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000l> > >(std::__1::chrono::time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000l> > >) const in lto.o
  "date::current_zone()", referenced from:
      currentDateTime() in lto.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

It doesn't seem that #9082 was resolved.

Here's a small, self-contained example illustrating the issue: https:/acgetchell/currentDateTime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date] link/build failure
5 participants