[many ports] Remove _find_package guards that break *_FOUND #12157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Several ports add guards before calling
_find_package
to prevent it from being called if a package's libraries and/or includes are in cache. However,*_FOUND
variables are not in the cache, and since calling find_package is generally expected to invoke the actualFind*.cmake
regardless, such guards are not only unnecessary (I'm not actually sure what the point of them was in the first place), but also break CMake lists using*_FOUND
if CMake is ever re-run (and MSVC loooooooooves to rerun CMake every 3 seconds).What does your PR fix? *_FOUND being missing if a package's libraries and/or includes are in cache
Which triplets are supported/not supported? Have you updated the CI baseline? No changes.
Does your PR follow the maintainer guide? Yes.