-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenCV] Update to v4.1.1 #5169
Conversation
Waiting on my other open PRs before asking this merge... |
Thanks to #5417 finally completed, I think that we can start discussing this PR @Codiferous. Please tell me if you see any regression, so that I can start fixing bugs and problems. It could be possible that some ports must be made dependent on |
btw, in parallel of the opencv3 rename, what's your opinion on #3360? Shall I close it and forget it? I think it could be interesting in some edge cases... and not dangerous in any way, am i right? |
In the PR test this is causing failures in zxing-cpp on x86-windows and x64-windows, which has a dependancy on openvc. |
@Rastaban thanks for noticing. I added a patch and |
Here are the test results. The left results column is the latest commit to this PR, the right results column is test results from master: Blank space means the port did not exist and Skip typically means somthing it has a dependancy on failed so it was not built.
Here are all of the failures logs: As a sidenote: We are working on getting the CI system out from behind the wall so you can see the results and poke around yourself. I'm not sure when that will happen though. Until then let us know if there are any logs that would be useful and we should be able to get them to you. |
I pushed some patches here and there, on the OpenCV dependencies. ovis is a little bit problematic to fix on non-windows, there is a strange ninja error I've never seen related to a non-expanded variable inside FLAGS. |
it was a really tedious work. There are so many broken libraries... 😢 😭 |
again, this PR has become a huge PR with many different packages involved. First time something similar was closed and rebuilt in many different parts, copying my work and without even cherry picking my commits (no trace left of it, at the beginning I accepted it but for me it is important to have trace of the work done), last time another admin here merged all of them (luckily picking my commits). I hope that now is ok in this way, also to have a positive feedback by the CI |
@Rastaban can you please give me an update of failures/pass, since the green mark is still a mirage? |
i also tested builds on windows with static library linkage (but dynamic crt) and with the latest commit now also this config is fully working (at least here, at least for me) |
While waiting for the logs, in order to understand what to fix next, I also have a problem to submit: due to the official Inside the file
it must be changed with
Shall we produce a regex in the portfile to accomplish this? Is anyone able to help me? (regex are not really part of my strength, at least for now :D ) |
@Rastaban Sorry for the ping, but do you have any news on the CI logs? |
I was already managing "nonfree" in opencv3/4, so the latest merge is only to resolve conflicts, but nothing should have been changed from before. |
Here are the latest test results:
And the log as below: |
I can't reproduce any libmupdf problem locally. I wonder what's the problem because I can clearly see the openjpeg.lib in the command line at linking stage and those missing symbols are exported by that lib. I have merged with master in the meantime, during the weekend I should have more free time to check remaining issues: I hope to see this PR closed soon, because it is becoming too huge to maintain |
is it because I didn't update the CONTROL files that maybe some ports are not rebuilt? |
#5625 might be the proper fix for the problem described in #5169 (comment). Which is not a problem discoverable with CI at the moment, due to absence of any test on built libraries, am I right? |
I imported also a patch for libmupdf which should fix also problems for x86 builds. |
I have fixed a similar problem in the past by doing a |
…cenit/opencv4
Thanks for merging. I was doing the same thing :) |
@vicroms vcpkg_configure_cmake does not contain the "WITH_HALIDE" new feature edit: OTOH, is it now possible to remove all the other |
Oops, forgot to add it.
|
Thanks for investigating that ffmpeg patch! I'll bring this issue to our team's offline discussion.
I'm hoping to merge this PR soon, are there any issues that you are aware that should be addressed first? |
Not any that I am aware. Please proceed with merging! Finally, what about versioning in the library filenames? Shall we keep it or remove? Since there can only be one version in Vcpkg |
Enjoy your vacations!
We think it's OK to remove the version from the library filenames. |
Since it wouldn't be bad to find OpenCV 4 when I will be back at work, I did the removal of versioning from windows library names |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
🎉🎉🎉🎉🎉 Finally after months of work this PR has been merged! Thanks to everyone that contributed with their feedback and specially to @cenit for having the willpower and patience to see this through! 😄 The plan in the future is to handle updates to OpenCV much faster, and I think all the improvements made to the port in this PR will enable us to achieve that goal. |
Thank you too, very much |
It has been an extremely long journey, with so many parallel PRs necessary to make this one see the light! Thanks to everybody. It has been difficult, but very satisfying |
@vicroms not sure we handled properly the meta-package thing you recently pushed.
not the nicest welcome to the latest OpenCV release. Without proper exposure in the metapackage, many features are hidden behind the opencv4 package... |
I will open soon another PR, trying to fix these things and also update OpenCV 3 to a proper status. Having OpenCV3 still around in a broken state is something I cannot stand, sorry |
That was a HUGE oversight on my part, the right thing to do is for the meta-package to expose all the features in |
Thanks for having fixed this quickly in #7659 |
Any feedback is welcome!
fixes: #2065
fixes: #2749
fixes: #2799
fixes: #3095
fixes: #3418
fixes: #4160
fixes: #4601
fixes: #4725
fixes: #4758
fixes: #5101
fixes: #5557
fixes: #5876
fixes: #6728
fixes: #6994