-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdal] Update to v3.5.2 #26676
[gdal] Update to v3.5.2 #26676
Conversation
The osg:arm64-windows error is unrelated. osg fails to find cmake package OpenEXR. Given a number of warnings, some of openexr's dependencies may need pkg-config/pkgconf. This problem could have been hidden by installation order in the recent openexr update. |
@dg0yt , when I tested the features by command
|
6205d6d
@JonLiu1993 Please test again. |
@dg0yt , when I tested the features by command
|
@JonLiu1993 Fixed bug in port lerc. |
@dg0yt , I tested again and the error persists
F:\Feature-test\gdal\vcpkg\buildtrees\gdal\install-x64-windows-static-rel-out.log: |
I will try to make a separate lerc update to 4.0. It will fix static builds, cf. Esri/lerc@384465e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for lerc have changed but the version was not updated
version: 4.0
old SHA: 9fce90d3d96f4afb8ffcf1b2e7484ee75aa78ed2
new SHA: 8f17f219451d5e3b4243b40a1ad6695cc98e469b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Stop pushing non-sense to my branch. CI for x64-linux is broken. |
All features are tested successfully in the folllowing triplet:
|
Updating GDAL to the latest version in vcpkg (microsoft/vcpkg#26676). Summary of the related changes: - GDAL is updated to version 3.5.2 - GDAL is now built using its new CMake build config (microsoft/vcpkg#22392) - Using GDAL's cmake build, this now correctly includes GEOS also on Linux and MacOS - Using pyogrio (including GEOS) and shapely together fails on MacOS when using a different GEOS version and if pyogrio is imported first (this is because shapely (specifically for MacOS) will use an already loaded GEOS for ctypes, while its cython code still uses the GEOS included in the wheel, giving a GEOS version mismatch _within_ different parts of shapely itself) -> avoid this issue by trying to import shapely first in our `__init__.py` - Further, the vcpkg setup of which GDAL dependencies are used has changed a bit in the refactor of the port to use GDAL's cmake build. This has some influence on which libraries are included (eg libxml2 and iconv are no longer included), see #161 (comment) for more details.
What does your PR fix?
Updates GDAL. Removes upstreamed patch.
Resolves Undefined reference to pcre2 with qtbase and gdal in combination #25941 (upstream change).
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes