[vcpkg baseline][osg] Fix port dependencies and build errors #26698

dg0yt · 2022-09-06T06:42:44Z

What does your PR fix?
- Don't force-import default features of dependencies, '"default-features": false' doesn't work with a dependency of a dependency(transitive dependency) #26664.
- Avoid atomics detection via non-portable try-run by setting input variables, fixing arm64-windows baseline regression and build errors ([gdal] Update to v3.5.2 #26676 (comment), [ffmpeg] srt support #26679 (comment)).
- Fix detection and export of OpenEXR/IlmBase dependency, now using official CMake config.
- Fix detection of dependencies which rely on pkg-config, such as gdal.
- Fix and tighten mapping from features to CMake setup.
Which triplets are supported/not supported? Have you updated the CI baseline?

unchanged, no
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

dg0yt · 2022-09-06T11:51:52Z

arm64-windows installation order:

2022-09-06T06:51:15.2619446Z RESULTS
2022-09-06T06:51:15.2628011Z     vcpkg-cmake:x64-windows: SUCCEEDED: 5.351 ms
2022-09-06T06:51:15.2636581Z     vcpkg-cmake-get-vars:x64-windows: SUCCEEDED: 3.749 ms
2022-09-06T06:51:15.2644986Z     vcpkg-cmake-config:x64-windows: SUCCEEDED: 2.938 ms
2022-09-06T06:51:15.2654228Z     expat:arm64-windows: SUCCEEDED: 11.84 ms
2022-09-06T06:51:15.2663388Z     zlib:arm64-windows: SUCCEEDED: 9.516 ms
2022-09-06T06:51:15.2671950Z     sqlite3:arm64-windows: SUCCEEDED: 17.52 ms
2022-09-06T06:51:15.2680657Z     openssl:arm64-windows: SUCCEEDED: 113.5 ms
2022-09-06T06:51:15.2691226Z     curl:arm64-windows: SUCCEEDED: 25.52 ms
2022-09-06T06:51:15.2700887Z     bzip2:arm64-windows: SUCCEEDED: 10.47 ms
2022-09-06T06:51:15.2709305Z     brotli:arm64-windows: SUCCEEDED: 29.66 ms
2022-09-06T06:51:15.2718168Z     libpng:arm64-windows: SUCCEEDED: 14.17 ms
2022-09-06T06:51:15.2727149Z     freetype:arm64-windows: SUCCEEDED: 32.78 ms
2022-09-06T06:51:15.2735812Z     egl-registry:arm64-windows: SUCCEEDED: 5.393 ms
2022-09-06T06:51:15.2744188Z     opengl-registry:arm64-windows: SUCCEEDED: 16.69 ms
2022-09-06T06:51:15.2752632Z     zstd:arm64-windows: SUCCEEDED: 15.86 ms
2022-09-06T06:51:15.2761550Z     pthreads:arm64-windows: SUCCEEDED: 11.17 ms
2022-09-06T06:51:15.2770176Z     lz4:arm64-windows: SUCCEEDED: 12.12 ms
2022-09-06T06:51:15.2778857Z     libiconv:arm64-windows: SUCCEEDED: 20.11 ms
2022-09-06T06:51:15.2787444Z     gettext:arm64-windows: SUCCEEDED: 17.7 ms
2022-09-06T06:51:15.2795956Z     dirent:arm64-windows: SUCCEEDED: 4.174 ms
2022-09-06T06:51:15.2804451Z     vcpkg-tool-meson:x64-windows: SUCCEEDED: 217.7 ms
2022-09-06T06:51:15.2812819Z     getopt-win32:arm64-windows: SUCCEEDED: 6.367 ms
2022-09-06T06:51:15.2820945Z     getopt:arm64-windows: SUCCEEDED: 3.549 ms
2022-09-06T06:51:15.2829602Z     gperf:x64-windows: SUCCEEDED: 4.713 ms
2022-09-06T06:51:15.2837861Z     pthread:arm64-windows: SUCCEEDED: 3.617 ms
2022-09-06T06:51:15.2846216Z     fontconfig:arm64-windows: SUCCEEDED: 42.53 ms
2022-09-06T06:51:15.2855018Z     liblzma:arm64-windows: SUCCEEDED: 56.48 ms
2022-09-06T06:51:15.2864036Z     libwebp:arm64-windows: SUCCEEDED: 29.94 ms
2022-09-06T06:51:15.2872902Z     libxml2:arm64-windows: SUCCEEDED: 48.79 ms
2022-09-06T06:51:15.2883223Z     openjpeg:arm64-windows: SUCCEEDED: 13.9 ms
2022-09-06T06:51:15.2892176Z     pkgconf:x64-windows: SUCCEEDED: 13.52 ms
2022-09-06T06:51:15.2903121Z     vcpkg-pkgconfig-get-modules:x64-windows: SUCCEEDED: 4.8 ms
2022-09-06T06:51:15.2911580Z     nlohmann-json:arm64-windows: SUCCEEDED: 21.01 ms
2022-09-06T06:51:15.2920609Z     libjpeg-turbo:arm64-windows: SUCCEEDED: 22.79 ms
2022-09-06T06:51:15.2929004Z     sqlite3:x64-windows: SUCCEEDED: 21.6 ms
2022-09-06T06:51:15.2937714Z     tiff:arm64-windows: SUCCEEDED: 16.13 ms
2022-09-06T06:51:15.2946668Z     pcre2:arm64-windows: SUCCEEDED: 30.91 ms
2022-09-06T06:51:15.2955853Z     jasper:arm64-windows: SUCCEEDED: 18.77 ms
2022-09-06T06:51:15.2964420Z     json-c:arm64-windows: SUCCEEDED: 17.44 ms
2022-09-06T06:51:15.2972826Z     libpq:arm64-windows: SUCCEEDED: 302 ms
2022-09-06T06:51:15.2981461Z     giflib:arm64-windows: SUCCEEDED: 11.66 ms
2022-09-06T06:51:15.2990419Z     openexr:arm64-windows: SUCCEEDED: 119.1 ms
2022-09-06T06:51:15.2999310Z     freexl:arm64-windows: SUCCEEDED: 9.854 ms
2022-09-06T06:51:15.3008088Z     geos:arm64-windows: SUCCEEDED: 239.5 ms
2022-09-06T06:51:15.3016782Z     proj:arm64-windows: SUCCEEDED: 105.5 ms
2022-09-06T06:51:15.3026034Z     libgeotiff:arm64-windows: SUCCEEDED: 20.46 ms
2022-09-06T06:51:15.3034861Z     librttopo:arm64-windows: SUCCEEDED: 15.27 ms
2022-09-06T06:51:15.3043537Z     vcpkg-pkgconfig-get-modules:arm64-windows: SUCCEEDED: 8.708 ms
2022-09-06T06:51:15.3051953Z     libspatialite:arm64-windows: SUCCEEDED: 56.04 ms
2022-09-06T06:51:15.3060342Z     qhull:arm64-windows: SUCCEEDED: 50.08 ms
2022-09-06T06:51:15.3069276Z     gdal:arm64-windows: SUCCEEDED: 353.2 ms
2022-09-06T06:51:15.3079285Z     ilmbase:arm64-windows: SUCCEEDED: 8.235 ms
2022-09-06T06:51:15.3088599Z     libgta:arm64-windows: SUCCEEDED: 13.69 ms
2022-09-06T06:51:15.3097268Z     osg:arm64-windows: BUILD_FAILED: 22.79 s

arm64-windows config log:

-- Found Freetype: optimized;D:/installed/arm64-windows/lib/freetype.lib;debug;D:/installed/arm64-windows/debug/lib/freetyped.lib (found version "2.12.1") 
-- Found JPEG: optimized;D:/installed/arm64-windows/lib/jpeg.lib;debug;D:/installed/arm64-windows/debug/lib/jpeg.lib (found version "62") 
-- Found Jasper: optimized;D:/installed/arm64-windows/lib/jasper.lib;debug;D:/installed/arm64-windows/debug/lib/jasperd.lib (found version "2.0.33") 
-- Found Iconv: D:/installed/arm64-windows/debug/lib/iconv.lib (found version "1.17") 
-- Found ZLIB: optimized;D:/installed/arm64-windows/lib/zlib.lib;debug;D:/installed/arm64-windows/debug/lib/zlibd.lib (found version "1.2.12") 
CMake Warning (dev) at D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (GTA).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  CMakeModules/FindGTA.cmake:11 (INCLUDE)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package)
  CMakeLists.txt:751 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
-- Found OpenSSL: optimized;D:/installed/arm64-windows/lib/libcrypto.lib;debug;D:/installed/arm64-windows/debug/lib/libcrypto.lib (found suitable version "3.0.5", minimum required is "3")  
-- Found ZLIB: optimized;D:/installed/arm64-windows/lib/zlib.lib;debug;D:/installed/arm64-windows/debug/lib/zlibd.lib (found suitable version "1.2.12", minimum required is "1") 
-- Could NOT find SDL2 (missing: SDL2_DIR)
CMake Warning (dev) at D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (Poppler-glib).  This can
  lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  CMakeModules/FindPoppler-glib.cmake:2 (INCLUDE)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package)
  CMakeLists.txt:762 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
CMake Warning (dev) at D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (RSVG).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  CMakeModules/FindRSVG.cmake:2 (INCLUDE)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package)
  CMakeLists.txt:763 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
CMake Warning (dev) at D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (GtkGl).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  CMakeModules/FindGtkGl.cmake:2 (INCLUDE)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:829 (_find_package)
  CMakeLists.txt:764 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
-- Found ZLIB: optimized;D:/installed/arm64-windows/lib/zlib.lib;debug;D:/installed/arm64-windows/debug/lib/zlibd.lib (found version "1.2.12") 
-- Found PNG: optimized;D:/installed/arm64-windows/lib/libpng16.lib;debug;D:/installed/arm64-windows/debug/lib/libpng16d.lib (found version "1.6.37") 
-- Found TIFF: optimized;D:/installed/arm64-windows/lib/tiff.lib;debug;D:/installed/arm64-windows/debug/lib/tiffd.lib (found version "4.4.0")  
-- Performing Test _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS
-- Performing Test _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS - Failed
-- Performing Test _OPENTHREADS_ATOMIC_USE_MIPOSPRO_BUILTINS
-- Performing Test _OPENTHREADS_ATOMIC_USE_MIPOSPRO_BUILTINS - Failed
-- Performing Test _OPENTHREADS_ATOMIC_USE_SUN
-- Performing Test _OPENTHREADS_ATOMIC_USE_SUN - Failed
-- Performing Test _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED
CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE (advanced)
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see D:/buildtrees/osg/arm64-windows-dbg/TryRunResults.cmake
-- Performing Test _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED - Failed
-- Performing Test _OPENTHREADS_ATOMIC_USE_BSD_ATOMIC
-- Performing Test _OPENTHREADS_ATOMIC_USE_BSD_ATOMIC - Failed
-- Found Fontconfig: D:/installed/arm64-windows/debug/lib/fontconfig.lib (found version "2.14.0") 
-- Found EXPAT: optimized;D:/installed/arm64-windows/lib/libexpat.lib;debug;D:/installed/arm64-windows/debug/lib/libexpatd.lib (found version "2.4.8") 
-- osgText will be linked with FontConfig library
CMake Warning (dev) at D:/downloads/tools/cmake-3.24.0-windows/cmake-3.24.0-windows-i386/share/cmake-3.24/Modules/Documentation.cmake:30 (message):
  Policy CMP0106 is not set: The Documentation module is removed.  Run "cmake
  --help-policy CMP0106" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  Documentation.cmake is VTK-specific code and should not be used in non-VTK
  projects.  This logic in this module is best shipped with the project using
  it rather than with CMake.
Call Stack (most recent call first):
  CMakeLists.txt:1163 (INCLUDE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- The following OPTIONAL packages have been found:

 * OpenGL
 * Jasper
 * LibXml2
 * GDAL
 * GTA
 * CURL
 * GIFLIB
 * JPEG
 * ZLIB
 * PNG
 * TIFF
 * Threads
 * Fontconfig
 * Freetype
 * EXPAT

-- The following OPTIONAL packages have not been found:

 * EGL
 * ilmbase
 * OpenCascade
 * COLLADA
 * FBX
 * LibVNCServer
 * DirectShow
 * SDL2
 * Poppler-glib
 * RSVG
 * GtkGl
 * DirectInput
 * NVTT
 * ZeroConf
 * LIBLAS
 * QuickTime

-- The following REQUIRED packages have not been found:

 * OpenEXR

So OpenEXR is not found despite being installed.
pkgconf is not found despite being installed. But note that it is installed for the host and for the target.

dg0yt force-pushed the osg-fix branch from 1e5b5e7 to 212624c Compare September 6, 2022 06:47

Adela0814 assigned LilyWangLL Sep 6, 2022

LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 6, 2022

dg0yt force-pushed the osg-fix branch from ef3da28 to 31a4d9e Compare September 7, 2022 05:36

LilyWangLL changed the title ~~Don't depend on default features [skip actions]~~ [osg] Don't depend on default features [skip actions] Sep 7, 2022

dg0yt force-pushed the osg-fix branch 2 times, most recently from 90f8d92 to 2d47007 Compare September 9, 2022 05:26

dg0yt added 4 commits September 9, 2022 16:23

Don't depend on default features

9d65e46

Use OpenEXR config

5156002

Try to skip non-portable check_cxx_source_runs

7119eea

Ensure PKG_CONFIG_USE_CMAKE_PREFIX_PATH

7d6de43

dg0yt force-pushed the osg-fix branch from f07be70 to de752a4 Compare September 9, 2022 14:39

dg0yt changed the title ~~[osg] Don't depend on default features [skip actions]~~ [osg] Fix port dependencies Sep 9, 2022

github-actions bot previously approved these changes Sep 9, 2022

View reviewed changes

dg0yt changed the title ~~[osg] Fix port dependencies~~ [osg] Fix port dependencies and build errors Sep 9, 2022

dg0yt added 3 commits September 9, 2022 17:08

Use link libraries from pkg-config

c51f25c

Revise feature-to-CMake mapping

9e893ec

Update versions

c7c2f28

dg0yt dismissed github-actions[bot]’s stale review via c7c2f28 September 9, 2022 15:22

dg0yt force-pushed the osg-fix branch from de752a4 to c7c2f28 Compare September 9, 2022 15:22

github-actions bot approved these changes Sep 9, 2022

View reviewed changes

dg0yt mentioned this pull request Sep 9, 2022

[vcpkg baseline][many ports] Fix baseline issues #26646

Merged

dg0yt marked this pull request as ready for review September 9, 2022 15:36

dg0yt mentioned this pull request Sep 11, 2022

[libspatialite] Fix host dependency #26741

Merged

JackBoosY self-assigned this Sep 13, 2022

JackBoosY changed the title ~~[osg] Fix port dependencies and build errors~~ [vcpkg baseline][osg] Fix port dependencies and build errors Sep 13, 2022

JackBoosY approved these changes Sep 13, 2022

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2022

dg0yt mentioned this pull request Sep 13, 2022

[ffmpeg] srt support #26679

Merged

JonLiu1993 mentioned this pull request Sep 13, 2022

[osg] Fix plugin installation and target locations #26214

Merged

JackBoosY mentioned this pull request Sep 14, 2022

[vcpkg] GENERATOR with Makefiles can build parallel #26780

Merged

m-kuhn mentioned this pull request Sep 14, 2022

[vcpkg script] Add support for Android to make and meson #26570

Closed

vicroms merged commit 62850c2 into microsoft:master Sep 14, 2022

dg0yt mentioned this pull request Nov 1, 2022

'"default-features": false' doesn't work with a dependency of a dependency(transitive dependency) #26664

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg baseline][osg] Fix port dependencies and build errors #26698

[vcpkg baseline][osg] Fix port dependencies and build errors #26698

dg0yt commented Sep 6, 2022 •

edited

Loading

dg0yt commented Sep 6, 2022

[vcpkg baseline][osg] Fix port dependencies and build errors #26698

[vcpkg baseline][osg] Fix port dependencies and build errors #26698

Conversation

dg0yt commented Sep 6, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

dg0yt commented Sep 6, 2022

dg0yt commented Sep 6, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?