Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-think PR creation flow #4403

Closed
isidorn opened this issue Jan 17, 2023 · 2 comments
Closed

Re-think PR creation flow #4403

isidorn opened this issue Jan 17, 2023 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@isidorn
Copy link

isidorn commented Jan 17, 2023

Feedback from @burkeholland: "Why do we have an intermediate view in the viewlet when creating a PR, why not just use a Custom Editor to make it look like something users on GitHub are used to?" Using the Custom Editor in the Editor view that looks like the final Summary view would also make the transition calmer.

A benefit of showing the Creation view in the viewlet is that it makes it easy for users to preview the files their PR is touching.

I would just like if we re-think this, and if we decide that the leaving it in the Viewlet is the way to go then we should see how to polish the current experience.

@alexr00 ideally we should add some telemetry to see what percentage of users see the Creation view and do not finish creating it. And then explore how can we improve those numbers?

fyi @daviddossett for ideas

Current view:
Screenshot 2023-01-17 at 15 08 50

@alexr00 alexr00 added the feature-request Request for new features or functionality label Jan 18, 2023
@alexr00 alexr00 added this to the February 2023 milestone Jan 18, 2023
@alexr00 alexr00 modified the milestones: February 2023, March 2023 Feb 16, 2023
@alexr00 alexr00 modified the milestones: March 2023, April 2023 Mar 17, 2023
@alexr00 alexr00 modified the milestones: April 2023, May 2023 Apr 21, 2023
@alexr00 alexr00 modified the milestones: May 2023, June 2023 May 10, 2023
alexr00 added a commit that referenced this issue Jun 15, 2023
This was referenced Jun 20, 2023
alexr00 added a commit that referenced this issue Jun 26, 2023
Add for compare only on new view
Part of #4403
alexr00 added a commit that referenced this issue Jun 26, 2023
@alexr00 alexr00 modified the milestones: June 2023, July 2023 Jun 26, 2023
alexr00 added a commit that referenced this issue Jul 4, 2023
and reuse quickpicks from the PR description
Part of #4403
alexr00 added a commit that referenced this issue Jul 4, 2023
and reuse quickpicks from the PR description
Part of #4403
@alexr00
Copy link
Member

alexr00 commented Jul 21, 2023

We will continue to polish this, but the create flow has been significantly updated:
image

@alexr00 alexr00 closed this as completed Jul 21, 2023
@isidorn
Copy link
Author

isidorn commented Jul 21, 2023

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants