Test new PR create views

[alexr00]

Refs: #4403

• anyOS @connor4312
• anyOS @aiday-mar
• anyOS @karthiknadig

Complexity: 5

Authors: @alexr00, @hbons

Create Issue

---

We have update the Create PR webview and the Files changed views. Please do exploratory testing on the "Create" views.

Setup:

• Install the pre-release build of the extension
• The new views are enabled by default already in the pre-release version
• Open a folder with a GitHub repository that you don't mind create PRs and pushing branches in
• To open the "Create" views, use the "Create Pull Request" command or the "Commit & Create Pull Request" button in the SCM view.

Specific features to test:

• Setting assignees, reviewers, labels, and a milestone from the create view
• After setting assignees/reviewers/labels/milstones, confirm everything in the webview is tabbable
• We try to guess your "into" branch better: If the branch you branched off from has an remote, then that will be your into branch. Otherwise, it will be the default branch for the repo
• In the branch selector, confirm ‘Change Repository…’ lists the repositories in the network
• The "Create" button remembers your last choice
• The "Files Changed" view shows changes even when your branch hasn't been pushed yet
• The "Files Changed" and "Commits" view update when you change branches or push your "from" branch.
• The controls in the webview are disabled when you open the view as we load the data for the view
• The controls in the webview are disabled after you click the "Create" button and while the PR is being created

[aiday-mar]

HI @alexr00, I am currently testing the work. While testing, I had the following thoughts:

1. It seems as though it is currently not possible to create labels (perhaps I have missed the button to do so). However it is possible to create milestones from the view. Do you think it would be useful to be able to create labels too?
2. After I set the assignee, the reviewer and the label I notice the following:

There appears to be little space between the reviewer/assignee name and their circular picture. Perhaps a little padding could make it better.
3. Concerning the Change repository... button, I was wondering what repositories exactly I should expect to see?Currently the only repository shown is the one I am currently on. I was expecting to see the other repositories I host on my account.

I like the new interface!

[alexr00]

It seems as though it is currently not possible to create labels (perhaps I have not missed the button to do so). However it is possible to create milestones from the view. Do you think it would be useful to be able to create labels too?

Seems like a reasonable feature rerquest!

There appears to be little space between the reviewer/assignee name and their circular picture. Perhaps a little padding could make it better.

@hbons already has a fix ready and is waiting on me: #5101

Concerning the Change repository... button, I was wondering what repositories exactly I should expect to see?Currently the only repository shown is the one I am currently on. I was expecting to see the other repositories I host on my account

You will only see repos that you have as git remotes.

[aiday-mar]

Hi @alexr00, I see better now thanks!